Missing var $current_display declaration? [#1170572]

Shoudn't the view class (or any of the ancestors) have a property var $current_diplay (or a magic method or a construct to initialize it)???
This property is later used in many places (e. g. views.inc line 214) :

$display_id = ($this->display_handler->is_defaulted('filters')) ? 'default' : $this->current_display;

Comment	File	Size	Author
#6	add--variable-to-view-class-issue-1170572-1.patch	399 bytes	neoglez
#6
#3	add--variable-to-view-class-issue-1170572.patch	405 bytes	neoglez
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

neoglez CreditAttribution: neoglez commented 27 May 2011 at 11:12

Category:

bug

» feature

Well, going over some forums i find different opinions, the php manual doesn't say much, but it's a fact that properties can be created dinamically inside any function.
I think it wouldn't hurt to make the declaration (i'm seeing some strange behaviors that could be related to this).

Comment #2

dawehner

German

CreditAttribution: dawehner commented 27 May 2011 at 11:44

Category:

feature

» task

Feel free to create a patch with a sane default value.

Comment #3

neoglez CreditAttribution: neoglez commented 27 May 2011 at 12:45

Component:	Miscellaneous	» Code
Status:	Active	» Needs review

File	Size
add--variable-to-view-class-issue-1170572.patch	405 bytes

Piece of cake ;-)

Comment #4

dawehner

German

CreditAttribution: dawehner commented 27 May 2011 at 17:39

Status:

Needs review

» Needs work

+++ b/includes/view.incundefined
@@ -60,6 +60,13 @@ class view extends views_db_object {
+   * @var current_display

@var is often used for the type of the var. Isn't string here something better.

Powered by Dreditor.

Comment #5

merlinofchaos CreditAttribution: merlinofchaos commented 27 May 2011 at 18:06

I think declaring vars we use for sure in the view is a good thing; it improves documentation tremendously to do it. We have to do mor ethan just have the var, we need to provide doxygen with what it has.

Also, it would be good to analyze the view object and see what ELSE we're missing.