1. Wording Customization
This may be going too far into custom user needs, but I think this would be a great option: To have a configuration field in which the user can specify the wording of "list" that shows in all parts of the module's display modes. The default is "List" or "Lists," including where a username is added such as "UserName's Lists." In the case of our site, we are using the term "Showcase" or "Showcases" because the lists are collections of visual material (videos) being assembled as examples for a specific purpose. So the only way that I, as a non-coder, was able to accomplish that was to open all files in the module set and go searching for all instances of "list(s)" and change to "showcase(s)" Is it feasible to add such a configuration option?

2. Flag List Operations widget
Currently it appears that the widget is placed above the view it is associated with. Is it feasible to have the option to expose it as a block, so it could be placed elsewhere such as in an adjacent column?

CommentFileSizeAuthor
#13 option_to_customize_wording-2465553-13.patch647 bytessl27257
#8 option_to_customize_wording-2465553-8.patch4 KBsl27257
#4 option_to_customize_wording-2465553-4.patch9.76 KBsl27257

Comments

sl27257’s picture

sl27257
Location Stockholm
commented

1) On the following page /admin/structure/flags/lists there is a possibility to "Substitute "list" with your own terminology". Maybe this could somehow be extended to what you are asking for?

2) This is unfortunately something that the "views" module generates. Without having to checked exactly how it is done I guess something might be done by theming the views module. However moving it into a block sound slightly more tricky to me.

opstao’s picture

opstao commented

On suggestion 1) – quite right, I don't think I ever saw that before! But from what I can determine so far, it only changes some not all instances where "List" is used. The Flags List widget still displays the header "List operations" and the dropdown displays "Add to list." Also the new list creation button displays "New List?" So as you suggested, perhaps it could be extended to be more comprehensive.

sl27257’s picture

sl27257
Location Stockholm
commented

I have done a first attempt to make it more comprehensive. I have some problems with Capitalization and plural forms. The first one can be solved if we agree were to use it. It might however create problem for translation. English and Swedish is however not a problem ;)

The "New List?" button is the trickiest. It is generated in Javascript. If I remember right Drupal has some support functions for this...

As you might understand I have only briefly started to look into it.

I will upload a first attempt containing the obvious and easier fixes later today. Let take it from there and fix it until we are (reasonable) satisfied...???

sl27257’s picture

sl27257
Location Stockholm
commented
StatusFileSize
new option_to_customize_wording-2465553-4.patch9.76 KB

This is the promised patch. It is by no means complete. It is relative the current -dev version, 7.x-3.0-beta1+4-dev . See it as a starting point for this suggestion.

/Thomas

opstao’s picture

opstao commented

Thanks for your work on this! Probably won't have a chance to test it for a while. Do you think there's a good possibility roll this, plus fixes for the issues pointed out in 2388741 comment 20, into a future revision?

sl27257’s picture

sl27257
Location Stockholm
commented

You are welcome!

These fixes is more a question on how much we want in a first release. There are some difficulties involved. The Javascript need to follow the PHP. As I wrote above I must find the Drupal-interface for that.

For #2388741-20: Special Characters? I have found what the problem is. The question is how to fix it. :) Javascript problem here as well (or the Json to be correct, I think)

  • sl27257 committed 65efb93 on 7.x-3.x 
    Issue #2465553 by sl27257: Feature Requests: Option to customize wording
sl27257’s picture

sl27257
Location Stockholm
commented
StatusFileSize
new option_to_customize_wording-2465553-8.patch4 KB

This is the rest of the fix, almost...

  1. It takes care of the pop-up window part. That is the selected list name is used in the pop-up window
  2. It also add a security feature. Hopefully this makes it harder to fake the Ajax-message.
  3. Finally it tries to remove the selection message in the pop-up window when there is only one item. This part works partly. Why I don't...
opstao’s picture

opstao commented

Looking forward to trying this. Should this patch be applied to 7.x-3.x-dev (April 27) ?

sl27257’s picture

sl27257
Location Stockholm
commented

That is correct. But maybe it is easier if I push the current patches to the -dev???

I have had these patches for some time on my test-server. So on that it is working. But as you know there are unsolved problems in your implementation.

/Thomas

BTW: The plural form of the list name is not yet implemented.

  • sl27257 committed bd237b8 on 7.x-3.x 
    Issue #2465553 by sl27257: Feature Requests: Option to customize wording...
opstao’s picture

opstao commented

Thanks! I see the changes have been moved to Dev and can confirm the improvements are working as described. (We still have another problem with overall function but that is in a separate discussion.)

sl27257’s picture

sl27257
Location Stockholm
commented
StatusFileSize
new option_to_customize_wording-2465553-13.patch647 bytes

Some changes to make it more "the Drupal way".

  • sl27257 committed f1cc8bf on 7.x-3.x 
    Issue #2465553 by sl27257: Feature Requests: Option to customize wording...
sl27257’s picture

sl27257
Location Stockholm
commented
Status: Active » Needs review
sl27257’s picture

sl27257
Location Stockholm
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.