alexpott's test issue

.

Test

Add a fail if the router needs to be rebuilt after setUp() in TestBase - #2164367: Rebuild router as few times as possible per request

Oops got it a bit wrong

So lets remove it a see what fails

url generator should not be persistent

Automated Alex!

Automated Alex!

Let's remove persisted services and see what breaks.

Trying to work out what is going on with #2216701: Random test failure in ToolbarAdminMenuTest

Going further back

FAILED * 9d3a228 - Issue #2171071 by jessebeach, dawehner, chakrapani, longwave, Gábor Hojtsy, xjm, Wim Leers: Rename drupal_add_library() to _drupal_add_library() and remove its uses. (27 hours ago)
TO TEST * 9a2cb6a - Issue #2134857 by Xano: PHPUnit test the entity base classes. (31 hours ago)
GOOD * 1fa8170 - Issue #2208497 follow-up by chx: Another new Migrate maintainer. (2 days ago)

https://www.drupal.org/node/2073811#comment-8994615 got me thinking...

#2073811-1: Add a url generator twig extension

Let's see what #attached][library keys are wrong.

Another try at that.

Third time's a charm

Debugging failures in #2232861: Create BrowserTestBase for web-testing on top of Mink

diff --git a/core/modules/simpletest/src/BrowserTestBase.php b/core/modules/simpletest/src/BrowserTestBase.php
index 443ece8..8c22cbc 100644
--- a/core/modules/simpletest/src/BrowserTestBase.php
+++ b/core/modules/simpletest/src/BrowserTestBase.php
@@ -217,6 +217,7 @@ protected function setUp() {
     // Get and set the domain of the environment we are running our test
     // coverage against.
     $base_url = getenv('SIMPLETEST_BASE_URL');
+    throw new \InvalidArgumentException('SIMPLETEST_BASE_URL=' . $base_url);
     if (!$base_url) {
       throw new \InvalidArgumentException('You must provide a SIMPLETEST_BASE_URL environment variable to run PHPUnit based functional tests.');
     }
diff --git a/core/modules/simpletest/src/Tests/SimpleTestBrowserTest.php b/core/modules/simpletest/src/Tests/SimpleTestBrowserTest.php
index c86933d..9d143e1 100644
--- a/core/modules/simpletest/src/Tests/SimpleTestBrowserTest.php
+++ b/core/modules/simpletest/src/Tests/SimpleTestBrowserTest.php
@@ -151,6 +151,8 @@ public function testTestingThroughUI() {
     );
     $this->drupalPostForm(NULL, $edit, t('Run tests'));
     $this->assertText('0 fails, 0 exceptions');
+    preg_match('/SIMPLETEST_BASE_URL=([^\s]*)/', $this->getRawContent(), $matches);
+    $this->assertEqual('', $matches[1]);
   }
 
 }
diff --git a/core/scripts/run-tests.sh b/core/scripts/run-tests.sh
index 6e9a950..0f8c330 100644
--- a/core/scripts/run-tests.sh
+++ b/core/scripts/run-tests.sh
@@ -80,6 +80,10 @@
 for ($i = 0; $i < $args['repeat']; $i++) {
   $tests_to_run = array_merge($tests_to_run, $test_list);
 }
+$tests_to_run = [
+  'Drupal\simpletest\Tests\SimpleTestBrowserTest',
+  'Drupal\Tests\simpletest\Functional\BrowserTestBaseTest',
+];
 
 // Execute tests.
 simpletest_script_execute_batch($tests_to_run);

The important bits of how I'm debugging this.

Trying again.

And again

That text was in the exception message look at the results from the patch in #76 - it worked perfectly I proved that the problem was not SIMPLETEST_BASE_URL

Suspicions...

APC testing

Required image

A commit happened.

A test comment...

Re EscapedMarkup I think we're missing the point that the markup representation of something like I like the <br> tag is I like the <br> tag

So what's the maximum size.

This issue takes too long to load.