Closed (fixed)
Project:
Panels
Version:
5.x-2.0-beta4b
Component:
Panel pages
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
31 May 2007 at 19:12 UTC
Updated:
31 Jul 2008 at 04:46 UTC
Jump to comment: Most recent file
Comments
Comment #1
gracearoha commentedi also would be interested in how to do this
Comment #2
jonhattanin the template node-groupcck.tpl.php:
print $titlethis shows both titles. you can put an empty title in the related panel as a workaround.
Comment #3
catchempty title in the panel is probably as good as this is going to get in 5.x-1.x, so marking as fixed.
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #5
pvasener commentedThis issue is still there on 5.x-2.0-beta2.
Here is a patch to panels_pages to keep the original node title is the panel page title is empty.
Comment #6
merlinofchaos commentedI believe the current behavior is the correct behavior, since this patch could make it impossible to get a blank page title if that's what you want.
The solution here is that OG needs a proper display manager, and not to use panels pages in a way that is not quite intended. Moshe told me yesterday he has achieved some funding to write this solution, so hopefully that means it will not be that far away.
Comment #7
sun#241067: Panel page titles cannot be reset from another module has been marked as duplicate of this issue. Proposed more or less exactly the same fix (but cleaner code), but related to user/% overrides, unrelated to OG. So maybe this should go in?
Comment #8
sunComment #9
sunBy trail'n'error I just found out that a node page override (node/%) displays the node title (through panel argument) only if '%node' is set as Panel title in the Panel configuration. The page title override in the Node ID argument configuration (which I've also set to '%node') is not recognized.
Comment #10
sunThat is, of course, only working at all with this patch applied: #213751: $node->title removed from template variables
Comment #11
sdboyer commentedAnd here we are, back in my favorite little circle of hell...here's hoping that this is the last round, and between your recent big patch and this one, we'll actually have this licked once and for all.
sun (or anyone else), if you could try out the patch here and let me know how it interacts with what's been set up thus far (including all the custom display titling, hiding/showing, etc) that'd be awesome. I don't really like the
drupal_set_title(''), but I'm at a loss as to what else we can do to ensure that the damn thing gets hidden.Comment #12
sdboyer commentedComment #13
sunWorks as expected.
I re-rolled your patch and turned the test plan into a HTML file placed in a new sub-directory /tests. I know this is very far from perfect, but I still think it's better than nothing. We will need to re-test this behavior each time something in the title logic changes (and update the test plan if necessary). That's a solid test plan and also a good reminder and/or starting point for writing SimpleTests (sometime in the future).
Comment #14
sdboyer commentedWoot. Committed.
As I said on IRC, we'll keep an eye on your thoughts re: testing, it's definitely a good baseline to start from.
Comment #15
sdboyer commentedWoot. Committed.
As I said on IRC, we'll keep an eye on your thoughts re: testing, it's definitely a good baseline to start from.
Comment #16
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.