Index: panels_page/panels_page.module =================================================================== RCS file: /cvs/drupal-contrib/contributions/modules/panels/panels_page/Attic/panels_page.module,v retrieving revision 1.1.2.62 diff -u -p -r1.1.2.62 panels_page.module --- panels_page/panels_page.module 14 Jul 2008 05:10:16 -0000 1.1.2.62 +++ panels_page/panels_page.module 14 Jul 2008 11:39:18 -0000 @@ -790,8 +790,11 @@ function panels_page_view_page($panel_pa return drupal_not_found(); } - if (!$display->hide_title) { - drupal_set_title(filter_xss_admin(panels_page_get_title($panel_page, 'page', ''))); + if (!$display->hide_title && $title = filter_xss_admin(panels_page_get_title($panel_page, 'page', ''))) { + drupal_set_title($title); + } + else { + drupal_set_title(''); } if ($panel_page->css) { Index: tests/panels_page.title.html =================================================================== RCS file: tests/panels_page.title.html diff -N tests/panels_page.title.html --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ tests/panels_page.title.html 14 Jul 2008 12:26:23 -0000 @@ -0,0 +1,77 @@ + + +Panels page title test plan + + + +

Panels page title test plan

+

Note: This is just a stub test for manual testing; a reminder for later SimpleTest integration.

+
    +
  1. Created a panel for path node/% and added the "Node ID" argument to contexts, enabled the Panel for all content-types, enabled "Use different default display", and enabled an "own display" for two of those content-types.
    2. +
  2. Set up the following title configuration: + +
    3. +
  3. Created node/1 of content-type Type1; node/2 of content-type Type2.
    4. +
  4. Visited node/1 and "Context title" was displayed as page title.
    5. +
  5. Visited node/2 and "Context title" was displayed as page title.
    6. +
  6. Enabled "hide title" option in layout settings for "Node ID 1 Type1".
    + Visited node/1 and no page title was displayed.
    + Disabled "hide title" option in layout settings for "Node ID 1 Type1". +
    7. +
  7. Removed/blanked out context settings title for argument "Node ID".
    + Visited node/1 and "Type1 argument display title" was displayed.
    + Visited node/2 and "Type2 argument display title" was displayed. +
    8. +
  8. Enabled "hide title" option in layout settings for "Node ID 1 Type1".
    + Visited node/1 and no page title was displayed.
    + Disabled "hide title" option in layout settings for "Node ID 1 Type1". +
    9. +
  9. Enabled "hide title" option in layout settings for "Node ID 1 Type2".
    + Visited node/2 and no page title was displayed.
    + Disabled "hide title" option in layout settings for "Node ID 1 Type2". +
    10. +
  10. Removed/blanked out layout settings title in tab "Node ID 1 Type1".
    + Visited node/1 and "Panel title" was displayed. +
    11. +
  11. Enabled "hide title" option in layout settings for "Node ID 1 Type1".
    + Visited node/1 and no page title was displayed.
    + Disabled "hide title" option in layout settings for "Node ID 1 Type1". +
    12. +
  12. Created node/3 of an unrelated content-type.
    + Visited node/3 and "Default argument display title" was displayed. +
    13. +
  13. Enabled "hide title" option in layout settings for "Node ID 1 Default".
    + Visited node/3 and no page title was displayed.
    + Disabled "hide title" option in layout settings for "Node ID 1 Default". +
    14. +
  14. Changed the panel path from node/% to node.
    + Visited node and "Default display title" was displayed. +
    15. +
  15. Enabled "hide title" option in layout settings in tab "Default".
    + Visited node and no page title was displayed.
    + Disabled "hide title" option in layout settings in tab "Default". +
    16. +
  16. Removed/blanked out layout settings title in tab "Default".
    + Visited node and "Panel title" was displayed. +
    17. +
  17. Enabled "hide title" option in layout settings in tab "Default".
    + Visited node and no page title was displayed.
    + Disabled "hide title" option in layout settings in tab "Default". +
    18. +
+

See also: original issue / test plan on drupal.org

+ +