This module is a simple unit conversion module, it provided Unit Conversion field for auto conversion. Useful for conversion currency rate, length, temperature etc.

Features

  • Centralize configuration page
  • Integrated with drupal's field system
  • 2 display formatter (regular or toggle)
  • Permission access for administration
  • Views supported (Tested on Views 7.x-3.8)

Requirements

Installation

  1. Download this module
  2. Extract to sites/all/modules
  3. Enable module

Instruction

  1. Go to configuration page for setting up unit conversion
  2. Add field type "Unit conversion" to any content type
  3. Add content (That contain "Unit conversion" field)
  4. Hooray! the unit will be auto conversion relative to the configuration in setting page

Future work

  • Separate to unit conversion group
  • Conversion field can be delete not need value

Project's page

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/bentino/2337775.git field_unit_conversion
CommentFileSizeAuthor
#7 check-bug-xss2.jpg40.82 KBsaniyat
#7 check-bug-xss.jpg55.05 KBsaniyat

Comments

ankitgarg’s picture

ankitgarg commented

1. Given Path git clone --branch 7.x-1.x bentino@git.drupal.org:sandbox/bentino/2337775.git
field_unit_conversion only accessible by you. Change it to git clone --branch 7.x-1.x http://git.drupal.org/sandbox/bentino/2337775.git field_unit_conversion
2. pareview.sh report have lot's of problems (test result).
3. You need to do some commenting in you module. All files are without comments.

ankitgarg’s picture

ankitgarg commented
Status: Needs review » Needs work
ankitgarg’s picture

ankitgarg commented
Issue tags: +PAreview: review bonus
bentino’s picture

bentino commented
Issue summary: View changes
bentino’s picture

bentino commented

Fixed but automate test by pareview.sh show some fault in *.css and *.js

bentino’s picture

bentino commented
Status: Needs work » Needs review
saniyat’s picture

saniyat commented
Status: Needs review » Needs work
Issue tags: -PAreview: review bonus
StatusFileSize
new check-bug-xss.jpg55.05 KB
new check-bug-xss2.jpg40.82 KB

Automated review:

Check this link http://pareview.sh/pareview/httpgitdrupalorgsandboxbentino2337775git. You will get a huge amount of errors on your module. Fix those according to the comment given by the PAReview.

Manual review:

UI related bugs:

  1. After enable the module, I go to the configuration page. There I can not able set Unit key. Cause both fields are readonly.
  2. Any way I entry the keys and when click add more the form appears. But it is hard to distinguish the fields of two sets. The UI should more user friendly that any one can easily distinguish the sets.


General Code related:

  1. When configuration form submitted, you truncate the table then save the all values. I think update the existing entry using delta is better than the table truncate.
  2. Code should be modular with separate files with appropriate comment.


3rd party Code Related:

  1. You have added font-awesome 3rd party font. But it is fully violation of Drupal 3rd party guidelines. Read more here https://www.drupal.org/node/422996


Code Security:

  1. Your Code is not secure. have Cross site scripting bug. Details in the attached image.

** Removing the PAReview: review bonus tag cause the author didn't done any manual review and I think it is added mistakenly.

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.