I am using CKEditor for my fields and for some reason when I'm typing in filtered or full text mode, the character counter will flash the number of characters left and then re-display the default maximum character limit length. If I navigate to another browser page and then back to the page I am editing, the character count displays the correct number of characters left.

Also, If I switch to plain text mode the character countdown always displays the number of characters left.

I see no javascript errors in my chrome console.

Would anyone know which javascript may be causing this?

I am using:

Maxlength 7.x-3.0-beta1+6-dev
Drupal 7.22
CKEditor 7.x-1.12+12-dev
Jquery Update 7.x-2.3-alpha1+0-dev

CommentFileSizeAuthor
#15 screen-flashe-ckeditor-copy-pasting.gif332.25 KBsukh.singh
#13 issue-2267849-13-CKEditor-counterflas-reset-to-max.patch476 bytesquiron
#5 issue-2267849-05-CKEditor-counterflas-reset-to-max.patch430 bytesd34dman
#2 counter-flashing-and-failing-with-ckeditor-2267849-2.patch550 byteskhaled.zaidan

Comments

yosepkur’s picture

yosepkur commented

Try to unbind keyup event that is set from the maxlength.js and it will works normally.

khaled.zaidan’s picture

khaled.zaidan commented
StatusFileSize
new counter-flashing-and-failing-with-ckeditor-2267849-2.patch550 bytes

I ran into the same issue.

I found out that CKeditor itself triggers the onChange event for the textarea (probably to allow any existing js code on the page to still function "properly"), but when it does, the textarea is actually empty, so the counter keeps on resetting.

Attached is a patch against dev to fix that. I just copy the value from the CK to the textarea every time it changes. I'm sure this doesn't result in any other problems, because CK already does this when you disable it and re-enable it.

khaled.zaidan’s picture

khaled.zaidan commented
Status: Active » Patch (to be ported)

Setting status to Patch to trigger the git script to have a look :)

Note: I didn't test what happens with tineMCE, but a similar fix can be applied for that as well.

murraybiscuit’s picture

murraybiscuit commented

patch #2 looks good to me
thanks for the work khaled. the flashing text was driving me nuts...

d34dman’s picture

d34dman commented
StatusFileSize
new issue-2267849-05-CKEditor-counterflas-reset-to-max.patch430 bytes

A different approach than the patch in #2 that worked for me.

danharper’s picture

danharper commented

Tested patch in #2 and it worked for me.

Cheers Dan

zil.arman’s picture

zil.arman commented
Status: Patch (to be ported) » Needs work

Both patches are counting till eleven and then disappear. They help with this flashing issue, but field limit still does not work.

The #5 patch also breaks the other counters on simple text fields.

steveoriol’s picture

steveoriol
Location Grenoble 🇫🇷
commented

patch #2 works for me.

kungfu4’s picture

kungfu4 commented

Hey all,

Thanks for the patches, and patch #2 appears to fix the flashing total, but I've noticed that when I input the first character, it interprets it as 10 characters (so if my limit was 2000, on the first key down, the total changes to 1990, and then works as anticipated, 1989, 1988, etc.) Has anyone else seen this happen? I'll let you guys know if I pinpoint the issue for myself.

Thanks

kungfu4’s picture

kungfu4 commented

Quick update, this is related to the html that is generated by CKEditor as switching to Plain Text or Full HTML (with view source enabled), the count works as intended. I checked this in the #2 patch as well as the original and I'm still seeing it. I don't know if that is with the scope of the group, but if I have time, I'll try to see if I can add a rule that will exclude tags from the count IF truncate HTML isn't enabled. That definitely presents some challenges. Just thought I'd share with the group.

Thanks!

kungfu4’s picture

kungfu4 commented

And now I see that the truncate HTML is supposed to do that...sorry for all the hubub

TorbenBP’s picture

TorbenBP commented

Thank you for patching this!
Patch #2 and #5 both worked for me with solving the flashing issue. But hitting return at the end of the textfield, starting a new paragraph, makes the curser go to the top of the text field. This seems to apply for both patches. Admitted a minor bug.

quiron’s picture

quiron
Primary language Catalan
Location Barcelona
commented
StatusFileSize
new issue-2267849-13-CKEditor-counterflas-reset-to-max.patch476 bytes

The patch #5 works for me but disable the counter in fields without editor. I added a condition to the patch to avoid this issue.

knalstaaf’s picture

knalstaaf commented

#13 does the job.

sukh.singh’s picture

sukh.singh commented
StatusFileSize
new screen-flashe-ckeditor-copy-pasting.gif332.25 KB

Thank a lot for patching this! Patch #2 works for the initial issue, however I am still seeing one more issue. When copy pasting text to the ckeditor, it shows flashing text. I am attaching a screengrab so that it should be more understandable.

This generally occurs when the limit has been crossed. In my case I have added 500 words limit, If I add more than 500 words to the ckeditor field this issue arises.

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
commented

Seems the patches here are assuming WYSIWYG module is in use. Can this module not be used with plain old CKEditor module?

redzeuf’s picture

redzeuf
he/him
Primary language French
Location Geneva
commented
Status: Needs work » Needs review

Hi, I put this issue as needs review for the patch #13

redzeuf’s picture

redzeuf
he/him
Primary language French
Location Geneva
commented
Status: Needs review » Reviewed & tested by the community

As I'm not posting the patch my self but just reviewed it I change as RTBC.

The website I'm working on actually use that patch on production until 4 years now...) this patch #13 from @quiron work like a charm for WYSIWYG with ckeditor and also with plain text...

And thanks to @knalstaaf to having confirmed that.

cedewey’s picture

cedewey
he/him
Primary language English
Location Denver, CO
commented
Category: Support request » Bug report
Status: Reviewed & tested by the community » Closed (won't fix)

We are only maintaining the Drupal 7 version of the module for critical security fixes, so I'm marking this Closed (works as designed). Thank you everyone for working on this issue. If you do want to maintain the Drupal 7 version, do reach out. We'd be happy to bring you on board as a maintainer.

I also encourage you, if you haven't already, to upgrade your site to Drupal 8/9. We are actively maintaining that version and you would enjoy all of the other features of the latest version of Drupal.

d34dman’s picture

d34dman commented

Thanks for the module :) I can consume this patch via composer, so not a biggie.