Currently when using plupload.module with jQuery >= 1.9, Firebug will capture a JS error message as below:
TypeError: $.browser is undefined
plupload.js (line 51)
...[browser] && Drupal.plupload.compareVersions($.browser.version, requirements[bro...
As refer to http://api.jquery.com/jQuery.browser/:
Description: Contains flags for the useragent, read from navigator.userAgent. This property was removed in jQuery 1.9 and is available only through the jQuery.migrate plugin. Please try to use feature detection instead.
A dirty workaround patch attached to remove the usage of $.browser; As a better alternative, we may consider using http://api.jquery.com/jquery.support/ instead?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2190007_1.patch | 2.95 KB | slashrsm |
| #1 | plupload-browser_is_undefined_jquery_gt_19-2190007-1.patch | 974 bytes | hswong3i |
Comments
Comment #1
hswong3i commentedComment #2
slashrsm commentedIt looks that this requirements checks test only if Firefox > 3.6, as FF 3.6 doesn't support multiple attribute properly. I'd say we can kill this checks as FF doesn't support this version any more.
_requirements are technically not API (while people could still use them via custom modules), so I'd say just kill it entirely. Other option would be to kill it in 7.x-2.x, make it recommended release and note on project page that 7.x-1.x works only with jQuery < 1.9.
Comment #3
hswong3i commentedTotally agree for kill it entirely ;-)
BTW, it is a bit confuse for me about label it for 7.x-2.x, as I didn't see any roadmap nor description about what's going on for 7.x-2.x branch. Will it support plupload > v2.0.0?
Comment #4
slashrsm commentedOK. Committed to 7.x-2.x.
That branch was introduced with one minor fix that could potentially cause API breake. It is mostly the same as 7.x-1.x. There is no real roadmap for it actually.
I am planning Plupload 2.x for D8 version. Not sure if I'm going to backport it though (help is always welcome of course).
Comment #6
robertom commentedPatch #2 apply clearly to 7.x-1.x and fix the problem, but isn't committed to 7.x-1.x
I reopen the bug and change the version affected
Comment #7
dave reidI agree this should also be committed to 7.x-1.x.
Comment #8
slashrsm commentedCommitted to 7.x-1.x.