Replace drupal_container() with Drupal::service() in the comment module

Added some modifications to previous patch and also changed module_exists() to Drupal::moduleHandler()->moduleExists()

+++ b/core/modules/comment/comment.views.inc
@@ -141,7 +141,7 @@ function comment_views_data() {
 
-  if (module_exists('language')) {
+  if (\Drupal::moduleHandler()->moduleExists('language')) {

@@ -360,7 +360,7 @@ function comment_views_data() {
-  if (drupal_container()->get('module_handler')->moduleExists('translation_entity')) {
+  if (\Drupal::moduleHandler()->moduleExists('translation_entity')) {

In these two the leading \ could actually be omitted.

It's not wrong in any way though (I just think we loosely agreed on omitting in procedural code), so marking RTBC anyway.

tstoeckler, ok, fixed in this patch

Yay! +1

No longer applies

curl https://drupal.org/files/2003498-replace-drupal_container-comment-module-2.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5927  100  5927    0     0   2395      0  0:00:02  0:00:02 --:--:--  2581
error: patch failed: core/modules/comment/comment.views.inc:360
error: core/modules/comment/comment.views.inc: patch does not apply
error: patch failed: core/modules/comment/lib/Drupal/comment/Plugin/views/field/NcsLastCommentName.php:37
error: core/modules/comment/lib/Drupal/comment/Plugin/views/field/NcsLastCommentName.php: patch does not apply

Looks good.

This no longer applies for me.

Re-rolled @webchick this reroll successfully applied to today's build. Hope it passes.

Yup.

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/field/NcsLastCommentName.phpundefined
@@ -37,7 +37,7 @@ public function query() {
-    $join = drupal_container()->get('plugin.manager.views.join')->createInstance('standard', $definition);
+    $join = \Drupal::service('plugin.manager.views.join')->createInstance('standard', $definition);

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/sort/NcsLastCommentName.phpundefined
@@ -28,7 +28,7 @@ public function query() {
-    $join = drupal_container()->get('plugin.manager.views.join')->createInstance('standard', $definition);
+    $join = \Drupal::service('plugin.manager.views.join')->createInstance('standard', $definition);

I think these can be injected into the plugin because it extends Drupal\views\Plugin\views\PluginBase

+++ b/core/modules/comment/lib/Drupal/comment/Tests/CommentFieldsTest.phpundefined
@@ -73,7 +73,7 @@ function testCommentEnable() {
+    $this->assertFalse(\Drupal::moduleHandler()->moduleExists('comment'), 'Comment module disabled.');

@@ -85,7 +85,7 @@ function testCommentEnable() {
+    $this->assertTrue(\Drupal::moduleHandler()->moduleExists('comment'), 'Comment module enabled.');

Should use $this->container->get

The patch no longer applied. Heres the reroll

Still needs work for #13.

I think these can be injected into the plugin because it extends Drupal\views\Plugin\views\PluginBase

Took care of this.

Should use $this->container->get

This was already implemented in core/modules/comment/lib/Drupal/comment/Tests/CommentFieldsTest.php.

Needs reroll...

git ac https://drupal.org/files/comment-2003498-16.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3629  100  3629    0     0   3419      0  0:00:01  0:00:01 --:--:--  7872
error: patch failed: core/modules/comment/comment.module:1325
error: core/modules/comment/comment.module: patch does not apply

Rerolled. alexpott: BTW this was my reroll script. :)

And back.

#19: comment.dic_move.2003498.19.patch queued for re-testing.

Bot can object.

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/field/NcsLastCommentName.php
@@ -7,6 +7,7 @@
+use Drupal\views\Plugin\views\PluginBase;

For some reason there we're adding an unnecessary use

Patch no longer applies.

Tag fix, WSSCI -> WSCCI.

Sorry for the noise, didn't check autocomplete.

reroll! Also, replacing global $user with Drupal::currentUser() in comment.module as well.

Re-rolled from #27 as the change to global user in #32 looks like scope creep? (And it's being done in #2061899: Remove references to global $user in Comment module)

Tag fix.

And back to RTBC.

Patch no longer applies.

Rerolled.
Some of the changes were already fixed in HEAD. so, the patch size is smaller.

Looks good.

Let's just get this in.

#38: comment-2003498-38.patch queued for re-testing.

Committed/pushed to 8.x, thanks!