Replace drupal_container() with Drupal::service() in the block module

hm, I will try to find problem and will fix it.

Hi,

I have submitted patch of respective issue.

Hi,

Please ignore above patch in #11 comment
Check this one.

Apology. I created patch in wrong way.
Now please review.

Need review.

@ashwinikumar, please use Drupal::request(); instead Drupal::service()->get('request');

Updated. Need review

@DmitryDrozdik I used Drupal::request(); instead Drupal::service()->get('request');
It's only at one place in block module But still test got failed.
Not sure where my patch is lacking.
Need direction.

-       $path_alias = drupal_strtolower(drupal_container()->get('path.alias_manager')->getPathAlias($path));
+       $path_alias = drupal_strtolower(Drupal::service()->get('path.alias_manager')->getPathAlias($path));

This is incorrect way to use, please use Drupal::service('path.alias_manager') for example above, and for all other places.

Updated issue summary.

#23: 2003058-replace-drupal_container-block-module_23.patch queued for re-testing.

It applyes OK

That doesn't mean it's fixed. It needs to get RTBC'd and committed first.

Ok, I'm sorry.

I take note for next times.

Than you very much.

+++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Plugin/Block/CustomBlockBlock.phpundefined
@@ -61,8 +61,8 @@ public function blockForm($form, &$form_state) {
+      \Drupal::service('plugin.manager.block')->clearCachedDefinitions();

We shouldn't be using \Drupal::service() in OO code, it needs injecting.

Re-roll and a new version with dependencies injected. We're also updating module_exists here, not sure we should be doing it in this patch but I added it anyway.

#30: replace-drupal-container-injected-30.patch queued for re-testing.

Assigning for review.

1. @@ -8,13 +8,46 @@
   +    $this->aliasManager= $alias_manager;
   

   Missing a space

2. @@ -64,7 +97,7 @@ protected function checkAccess(EntityInterface $entity, $operation, $langcode, A
   +        $path_alias = drupal_strtolower($this->aliasManager->getPathAlias($path));
   

   Unicode::strtolower

Both issues in #33 fixed. Should drupal_strtolower() be marked as deprecated if we're not using it anymore?

I guess it should.

Committed 58d8e35 and pushed to 8.x. Thanks!