I have the following warnings when using FAPE, Panels IPE, and Organic Groups. (I'm integrating OG into Panopoly.)

The warnings occur when og_field_access($op, $field, ...) tries to access $field['field_name'] for $field= 'group_group'.

    Warning: Illegal string offset 'field_name' in og_field_access() (line 592 of /sites/all/modules/og/og.module).
    Warning: Illegal string offset 'field_name' in og_ui_field_access() (line 773 of /sites/all/modules/og/og_ui/og_ui.module).
    Warning: Illegal string offset 'field_name' in og_field_access() (line 592 of /sites/all/modules/og/og.module).
    Warning: Illegal string offset 'field_name' in og_ui_field_access() (line 773 of /sites/all/modules/og/og_ui/og_ui.module).

FAPE is passing $field_name instead of a full field structure array to field_access() [inside of fape_panels_pane_content_alter] which then cascades down to og_field_access().

CommentFileSizeAuthor
#17 fape-n1846156-17.patch3.19 KBdamienmckenna
#12 Screen Shot 2013-12-18 at 1.58.48 PM.png76.25 KBsaltednut
#6 panopoly_core-patch-fape-1981494-6.patch411 byteshydra
#5 fape-1846156-5.patch3.07 KBpancho
#3 fape-1846156-3.patch3.04 KBpancho
#2 fape-1846156-2.patch2.66 KBpancho
#1 fape-1846156.patch764 bytesericras

Comments

ericras’s picture

ericras commented
Status: Active » Needs review
StatusFileSize
new fape-1846156.patch764 bytes
pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
StatusFileSize
new fape-1846156-2.patch2.66 KB

I can confirm the bug, and the patch #1 fixes it.
I just refactored the code a bit, so it is less redundant and more readable, so either of the two should be fine. But please do some testing!

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
StatusFileSize
new fape-1846156-3.patch3.04 KB

Same bug in fape_field_edit_page(), leading to some more of the same warnings:

    Warning: Illegal string offset 'field_name' in og_field_access() (line 594 of /sites/all/modules/contrib/og/og.module).
    Warning: Illegal string offset 'field_name' in og_ui_field_access() (line 792 of /sites/all/modules/contrib/og/og_ui/og_ui.module).

Enclosed patch should fix both bugs, but please do some thorough tests.

kclarkson’s picture

kclarkson commented

I am confirming that the patch applied cleanly and has fixed the error message.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
StatusFileSize
new fape-1846156-5.patch3.07 KB

The same patch, but a bit simplified. We don't really need the helper function I added in #2.
From what my tests say, it works fine.

hydra’s picture

hydra commented
StatusFileSize
new panopoly_core-patch-fape-1981494-6.patch411 bytes

This should proabably be updated to the newest version of Pancho's patch. Still needs review, works for me.

mpotter’s picture

mpotter commented
Status: Needs review » Reviewed & tested by the community

Using this (#5) in Open Atrium 2 without any problem.

das-peter’s picture

das-peter commented

Patch from #5 looks good and I can confirm that it solves the problem.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

We're using #5 in Demo Framework. RTBC++

mrfelton’s picture

mrfelton commented

Now using #5 in the Panopoly distribution too.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Issue summary: View changes
saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new Screen Shot 2013-12-18 at 1.58.48 PM.png76.25 KB

I believe there may still be something going on here. I am seeing errors in the logs but not on every page. Can anyone confirm?
Error appears to have been environmentally specific. Sorry about that.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Needs work » Reviewed & tested by the community
saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
drupalycious’s picture

drupalycious commented

I confirm that patch#5 fixed the following errors:

Illegal string offset 'field_name' in og_ui_field_access() (line 823 of /.../sites/all/modules/og/og_ui/og_ui.module).
Illegal string offset 'field_name' in og_field_access() (line 588 of /.../sites/all/modules/og/og.module).

Will it be committed?

nlambert’s picture

nlambert commented

#5 works for me

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new fape-n1846156-17.patch3.19 KB

Thanks for the patch, I'm committing it after making a minuscule tweak or three.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

  • Commit da0007a on 7.x-1.x by DamienMcKenna: 
    Issue #1846156 by Pancho, ericras: Incorrect usage of field_access().
saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

w000t!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2050659: META: Plan for FAPE 7.x-1.2 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

cmonnow’s picture

cmonnow commented

Just some trivia...this bug only reared its head when I upgraded from PHP 5.3 to PHP 5.5.