Closed (fixed)
Project:
Edit
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
15 Mar 2013 at 08:51 UTC
Updated:
4 Jan 2014 at 02:58 UTC
Jump to comment: Most recent
Will be updated as I go along.
Comments
Comment #1
wim leersFirst one done: #1891246-6: White background through JS.
Comment #2
wim leers#1830518-12: Views integration (use Views' render pipeline to re-render edited fields in Views)
Comment #3
wim leers#1893638-12: [Firefox bug] Cursor doesn't show up when using the "direct" or "ckeditor" PropertyEditor widgets: complete revert.
Comment #4
wim leershttp://drupalcode.org/project/edit.git/commitdiff/d1623e3859b3e67bd64cdb..., for #1893644: Alignment slightly off on validation errors: unnecessary by moving to D8 HTML+structure for toolbar, that fixed this problem indirectly, so this hack is no longer necessary :)
http://drupalcode.org/project/edit.git/commitdiff/46204854bc446b0b60a844..., for #1893646: display:inline fields are floating around as I hover over them: likewise. Plus, this diff introduced changes unrelated to what the commit msg + issue were about, so just reverted the entire patch. With the exception of this change
Committed: http://drupalcode.org/project/edit.git/commit/e590058
As of this commit, the following files are IDENTICAL IN D7 & D8 , with exceptions noted:
css/edit.cs(98%), D7 has "Edit overlay"-related styles, which D8 does not have/needjs/createjs/editingWidgets/drupalcontenteditable.js(100%)js/createjs/editingWidgets/formwidget.js(90%), D7 contains.edit-belowoverlayclass handling wrt the overlay that the D7 version still hasjs/createjs/editable.js(99.9%), onlyDrupal.settingsvs.drupalSettingsjs/createjs/storage(100%)js/models/edit-app-model.js(90%), D7 has isViewing, D8 not; D8 has activeEntity, D7 does not. These differences stem from the fact that in D7, Edit has a "global edit mode", whereas in D8, you do in-place editing on a per-entity basisjs/createjs/viejs/EditService.js(99.9%), onlyDrupal.settingsvs.drupalSettingsjs/models/views/modal-view.js(90%), D7 contains.edit-belowoverlayclass handling wrt the overlay that the D7 version still hasjs/models/views/propertyeditordecoration-view.js(100%) → OMG! BIG WIN!js/models/views/toolbar-view.js(100%) → OMG! BIG WINjs/app.js(80%), D7 has global edit mode, D8 per-entity, this results in unavoidable differences. Plus: overlay vs. no overlay.js/backbone.drupalform.js(100%)js/edit.js(50%), D7 has async Create.js PropertyEditor loading (D8 not yet), ARIA messages area (handled byDrupal.announcein D8), global vs. per-entity edit mode and corresponding Backbone Router. Only natural that these are so different.js/theme.js(85%), D7 has two theme functions the D8 version doesn't need (for ARIA messages)js/util.js(99.9%), onlyDrupal.settingsvs.drupalSettings