Clean info files of unneeded files declarations. Change module description.

#3: gmap-remove_useless_files_in_info-1928834-3.patch queued for re-testing.

#5 looks good
For a feature - please, provide interdiff.txt for updated patches

Thanks!!!

This needs test against prev release. Bot?

#5: gmap-remove_useless_files_in_info-1928834-5.patch queued for re-testing.

#5 commited pushed to 7.x-2.x
needs backport to 7.x-1.x

commited pushed to 7.x-1.x
http://drupal.org/commitlog/commit/1080/911af76db134ef48f3ac16c724aef106...
thanks!!!

back to latest dev

This patch was not correct, and breaks my installation.
My views were removed from the system because the Views support was removed.

the views.inc be be removed, but gmap.module lacks a hook_views_api().
the view plugins are classes and MUST be declared.

BTW, since the only thing GMap does, is providing Views support, IMO we can move (almost) all code from gmap.module to gmap.views.inc. Only gmap_views_api must stay. (Perhaps other stuff, too)

The big module file is loaded on every page.
views.inc is loaded only on Vews pages.
It save memory and compile tiem on every page load.

#16 looks like code refactoring ( nice idea for follow-up with a test coverage for that )

+++ b/gmap.moduleundefined
@@ -51,6 +51,12 @@ function gmap_defaults() {
+function gmap_views_api() {
+  return array(
+    'api' => 3,
+  );
+}

why this code is in this patch?
Looks like it is from somewhere else

#11 and #5 reverted for devs

http://drupal.org/commitlog/commit/1080/ec77bfc3336412672b9e6baf7ee4c723...

http://drupal.org/commitlog/commit/1080/3c977ac6e05d031b8f0271efad8d86b2...

this needs test coverage too
please use /tests/gmap.test for that

tags

I'm glad this is reversed.

Regarding your comment #17:
- the hook_views-api() is mentioned in every tutorial, but all works fine without, too, indeed.
- yeah, no rush to move everything to views.inc ATM. You're doing enough refactoring already. Good job!
- the following files must stay in .inf file:

files[] = gmap_plugin_style_gmap.inc
files[] = gmap_plugin_style_gmapextended.inc
files[] = tests/gmap.test

@DuaelFr, that can happen to anyone,
@podarok, seems like a 'needs test' ;-)

@DuaelFr, IMO you patch is not agains latest dev version, since all patches are reversed, according to #18.

patch with do-not-test can`t be tested by bot )
Another patch has to be rerolled

@DuaelFr

git checkout 7.x-2.x
git pull --rebase
git add .
git commit
git diff pre_comit_id > id.patch
interdiff old.patch id.patch > interdiff.txt
...upload id.patch interdiff.txt with needs review status and 7.x-2.x version
git checkout 7.x-1.x
... make changes into files
git add .
git commit
git diff pre_comit_id > id2.patch
interdiff old.patch id.patch > interdiff2.txt
...upload id2.patch interdiff2.txt with needs review status and 7.x-1.x version

Thanks!!!!

new patch.

Better title

tagged for 7.x-2.5 release
#1932378: [META] gmap-7.x-3.0 release roadmap

added tag

I am not sure what 'needs work' (Indeed, I should have opened a new issue for the description.)
See a better patch attached.

testbot.

this issue changed by me for upcoming #1932378: [META] gmap-7.x-3.0 release roadmap as need work task for me when commiting it
so
RTBC +1
changing status as need work for myself

#30: gmap2_1928834_30_info_file.patch queued for re-testing.

#30 commited pushed to latest dev
http://drupal.org/commitlog/commit/1080/496d75cf44d2cf0380a51ea0497c2533...

Thanks!!!