Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
book.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Feb 2013 at 22:06 UTC
Updated:
29 Jul 2014 at 21:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
gabriel.achille commentedComment #2
gábor hojtsyTag for configuration schema.
Comment #3
vijaycs85Adding schema file...
Comment #4
vijaycs85updating key.
Comment #6
vijaycs85Updating space issue with "mapping"...
Comment #7
gabriel.achille commentedComment #8
vijaycs85Updated code style and verified with config_inspector

Comment #9
vijaycs85Ignore patch in #8. Updating correct patch file(screenshot in #8 applicable for this patch).
Comment #10
gábor hojtsyRestore tags.
Comment #11
yesct commentedI looked at the (one) data yml file and the schema file side by side and visually inspected them. They looked to match.
http://drupal.org/node/1910624#steps-to-test
The schema file is in the schema directory (good). #1914366: Move all configuration schema files into a schema subdirectory
The inspector module, shows the form looking good. (example review instructions: #1910624-9: [META] Introduce and complete configuration schemas in all of core)
I also looked at the schema for code style, and it meets it (http://drupal.org/node/1905070#codestyle).
rtbc for that.
aside question:

why is there a 0 with the default config? I thought it might be the element in the array (sequence).
but if I change the config and add more allowed types,

the 0 index goes away.

Comment #12
yesct commentedrelated to #11 #1928082: Make usage of book.settings:allowed_types consistent
Comment #13
webchickCommitted and pushed to 8.x. Thanks!