I have already converted core/modules/block/block-admin-display-form.tpl.php I want to have the permission to push to the sandbox, I want to contribute more templates conversion also, the attached is the file I worked on.

CommentFileSizeAuthor
#11 d8tts-block-admin-display-1818678-11.patch7.96 KBartofeclipse
#7 convert_block_admin_display_form_to_twig-1818678-7.patch2.39 KBartofeclipse
#5 block-admin-display-form.html_.twig_.txt2.01 KBartofeclipse
block-admin-display-form.html_.twig_.txt2.03 KBartofeclipse

Comments

artofeclipse’s picture

artofeclipse commented
Category: support » task
Status: Active » Needs review
artofeclipse’s picture

artofeclipse commented
Title: Covnver core/modules/block/block-admin-display-form.tpl.php to twig » Convert core/modules/block/block-admin-display-form.tpl.php to twig
markabur’s picture

markabur commented

Should be tbody here and in the closing tag:

</thead>
<body>

No need for single quotes around region-empty:

<tr class="region-message region-{{ region }}-message {% if block_listing.region is empty %} 'region-empty' {% else %} region-populated {% endif %}">

Is the "else" part really necessary here?

{% if data.row_class is not empty %} {{ data.row_class }} {% else %} {{ '' }} {% endif %}">
markabur’s picture

markabur commented
Status: Needs review » Needs work
artofeclipse’s picture

artofeclipse commented
Status: Needs work » Needs review
StatusFileSize
new block-admin-display-form.html_.twig_.txt2.01 KB

fixed the issues in the attached file

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented
Status: Needs review » Needs work 
  <body>

<tbody> should be here

  </body>

please, close <tbody> tag.

Could you add patch in diff format?
git diff old_revision_number your_commit_revision_number > problem-description-issue_id-comment_id.patch
Thx!

artofeclipse’s picture

artofeclipse commented
Status: Needs work » Needs review
StatusFileSize
new convert_block_admin_display_form_to_twig-1818678-7.patch2.39 KB

I don't know if the patch in the right format

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented
Status: Needs review » Reviewed & tested by the community

looks like very good!

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Reviewed & tested by the community » Fixed

#7 + RTBC

Thanks!

commited / pushed to front-end

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

artofeclipse’s picture

artofeclipse commented
Component: Twig templates » Twig templates conversion (front-end branch)
Status: Closed (fixed) » Needs review
StatusFileSize
new d8tts-block-admin-display-1818678-11.patch7.96 KB

the attached patch contains a rewrite for the template and removing the structure control from the template, I think there must be a better way to implement template_preprocess for this template but for now this it, and also I need to fix the drag and drop functionality in template, if someone have an idea please advice.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs review » Closed (duplicate)

Thanks @artofeclipse! I'm working on a patch in the core queue and I've based the block-admin-display-form on your patch :)

star-szr’s picture

star-szr
he/him
Primary language English
commented

Oops, link: #1898034: block.module - Convert PHPTemplate templates to Twig

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 1750250)