Do not list entity types that do not integrate with ET in the admin page

I guess Entity Translation should not list configuration entities. It does not make sense to translate a rule configuration entity?

We have two issues here: one is the ability to translate the Rules configuration and one is that ET should not list as translatable types the entity that do not support translation via ET.

@klausi:
I never tried rules_i18n but I know it relies on i18n's string translation. Does it cover the use case presented by @quiptime? If so, I'd say Rules do not need to integrate with ET as it already provides a translation method. ET just needs to stop listing Rules configurations among the translatable entity types. Otherwise Rules needs to integrate with ET and on that front there is nothing to do on the ET side (besides fixing the UX of the admin page).

This is surely not a major bug in any case.

Here is a patch: it hides from the list of entity types that can be enabled those not defining a valid base path.

+++ b/entity_translation.admin.inc
@@ -25,12 +25,33 @@ function entity_translation_admin_form($form, $form_state) {
+      // Clear warning messages.
+      drupal_get_messages('warning');

Theoretically there could be warnings unrelated to ET which would be cleared by this as well... should probably grab them before our validation and then insert them again if necessary.

Edit: it might be even better if we add a parameter to the validation function so we can avoid that call.

It might be even better if we add a parameter to the validation function so we can avoid that call.

Done :)

Looks good to me :)

Committed and pushed, thanks.

Long fixed...