uc_recurring Drupal 7 port

Subscribing

Hey univate,

I saw that you posted your thoughts on "Payment Specifications" to the Drupal Commerce site awhile back:

http://www.drupalcommerce.org/node/152

Has any progress been made on that? Do you have any plans in the works to bring recurring payment functionality to Drupal Commerce in D7?

Recurring payments is a must for us, but I'd rather be using Drupal Commerce than Ubercart in D7.

--Ben

Subscribing

Subscribing

This patch fixes some of the issues that I had while installing the D7 version.

I've also converted a couple of the queries to the D7 DBAPI syntax and reviewed some of the others. This patch should fix other issues with the Subscription Manager. There are still a couple errors that show up on the screen but I figured I'd submit this patch now as forward progress.

Other issues I've tried to fix with this patch
#1033474: tablesort_sql function no longer in D7
#1057936: Syntax error on install of uc_recurring module

Sorry about that. I got a bit overly excited it would seem.

Subscribing.

Any time frame for when this module will work with UC 3.x?

sub

subscribing :)

@aaronott, @univate, or anyone else...

How much will it take to get a full D7 release by the end of July? From what I can tell, we're only missing the port of CA to Rules.

I'm willing to chip in, and there may be some others as well from the looks of this post.

I would chip in as well.

I will chip in as well.

I'd also really like to get a fully functioning version of this module. A project I am working on has a budget available for this too - so we'd be more than willing to fund this knowing how much is involved.

There are a few more bug fix patches for 7.x-2.x-dev in the issue queue now. Adding them as I go.

For ease, here are my fixes in a single patch for
#1278406: Fee title is incorrectly set in uc_recurring_order_process_order()
#1278430: Undefined variable $user in uc_recurring_order_process_order()
#1254930: Call to undefined method SelectQuery::count()
#795094: Undefined variable and undefined property of non-object when adding a new recurring fee product feature
#1278540: uc_recurring_order_process_order() returns a non-existent variable $return
#1278542: uc_recurring_product_process_order() returns a non-existent variable $return
#1268010: Undefined properties of order in uc_recurring_get_fees()

Finding more things today so I will not keep creating issues for each.
I'll post a new version of the patch in #19 soon with more fixes.

Here is my latest patch.
It is inclusive of the stuff in #19 so you can ignore that one.

I have only been using recurring products and to a lesser extent (so far) recurring orders.
I have not even enabled recurring hosted or recurring subscription so this doesn't cover that.
Haven't had a chance to do ca > rules yet either.

From my testing most of the issues and notices etc. are now gone but I'm sure a couple might have slipped through somewhere.

I think there are still some issues I've noticed but haven't fixed yet and I have added issues for those to the issue queue.

I might close the other issues I opened that contain patches that are now merged into this big one.

New patch with more fixes.
Again, it includes the previous fixes in #21 & #19 so disregard them.

I have done a fair bit more testing with recurring products and orders now and it seems pretty stable.

Still no ca > rules yet.

Porting token support still needs to be done also.

A couple more fixes included in this one.

Still outstanding is:
1. Port ca > rules
2. Port token support
3. Someone test uc_recurring_hosted and uc_recurring_subscription

First cut at token porting.

Hi Guys,

Very interested in using this port once its complete. I am very pleased to see so much activity in here. Thanks to all of you putting in the skill and time to make this happen.

Sorry if I am being stupid here - but is there somewhere I can download the current code?
The download on the project page appears to be older than some of the patches listed on here. Is there a repo where I can grab the most recent code from for testing or do I need to download the code and then apply each of the patches in turn?

Download the current dev version and download the patch in #24 and apply it.
put the patch in the uc_recurring module directory you can apply with:
patch -p1 < uc_recurring-d7_fixes-992252-24.patch

There is also some more info around, like http://drupal.org/patch

If you want token support also apply the patch in #25

Any feedback if you find any bugs would be great.

Also note that rules support has not been finished yet.

subscribing

Subscribing

Naive question re:#24. Is there remnants of conditional actions that still work in the D7 port? Or will this simply not work until that is in place?

@Agileware. I have a huge client need on this one. I'll start digging into your patches and seeing if I can get those remaining items done.

If there are any other outstanding issues, please let me know. I'm basically free labor for you at this point :)

Merged the changes in 24+25 together and fixed three other issues.

1. JOIN users to JOIN {users}
2. uc_referer_uri -> referer_uri() #273574: Reduce HTTP_REFERER checks as per
3. Add a super basic set of shell functions for rules in uc_recurring_subscriptions

Fixed one mistake in #33. It's request_uri() not referer_uri()

Tests using a developer authorize.net account are going through. I'm seeing the recurring fees go through, getting the authorize.net emails going through, etc.

Still to test:
- getting errors on checkout from uc_coupon and uc_recurring_authorizenet_cim_renew()
- need to port ca to rules as per #24 above
- need to test tokens

Lots of issues on the subscription form. Working them out now...

Notice: Undefined property: stdClass::$initial_charge_value in uc_recurring_subscription_product_form() (line 183 of /Library/WebServer/htdocs/devel7/trunk/public_html/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined property: stdClass::$initial_charge_unit in uc_recurring_subscription_product_form() (line 196 of /Library/WebServer/htdocs/devel7/trunk/public_html/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: default_options in uc_recurring_subscription_product_form() (line 243 of /Library/WebServer/htdocs/devel7/trunk/public_html/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: default_option in uc_recurring_subscription_product_form() (line 244 of /Library/WebServer/htdocs/devel7/trunk/public_html/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined property: stdClass::$subscription in uc_recurring_subscription_product_form() (line 281 of /Library/WebServer/htdocs/devel7/trunk/public_html/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 281 of /Library/WebServer/htdocs/devel7/trunk/public_html/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined property: stdClass::$subscription in uc_recurring_subscription_product_form() (line 289 of /Library/WebServer/htdocs/devel7/trunk/public_html/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 289 of /Library/WebServer/htdocs/devel7/trunk/public_html/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined property: stdClass::$subscription in uc_recurring_subscription_product_form() (line 297 of /Library/WebServer/htdocs/devel7/trunk/public_html/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 297 of /Library/WebServer/htdocs/devel7/trunk/public_html/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).

Fixing the some of the problems posted in #36 and #1284666: UC Recurring Subscription Creation Page is broken
This is one big patch including all previous patches

The biggest issues I'm coming across are surrounding the forms in uc_recurring_subscription.admin.inc. There are a lot of uses of default variables that aren't defined, etc.

Sweet! Thanks univate. I'll be plugging along today and see if I can cleanup the subscription forms and knock that out.

Thanks for moving the ball up the field. I have a meeting for an hour but will jump back on this right after.

Question: I've used recurring fees before but not subscription. I also don't want to submit any changes/edits that deviate the functionality from your intent. Is there a 2-4 sentance overview about what the subscription module is supposed to do on top of the recurring fees?
http://drupal.org/documentation/modules/uc_recurring

I'll figure it out eventually once I poke around some more. But I didn't know if there was a cut and dry answer regarding the differences/benefits of adding the subscription submodule because I may be able to get away just with the fees functionality.

Thanks for the followup. I might focus more on other tickets then as I thought it might add features on top instead of simply package in a different way. Since I'll be the one operating, I'm not too worried about the interface.

Final question: If one setups ups a straight uc_recurring_products and then wants to upgrade, will it essentially be a new interface on top or are they considered completely different implementations of the same feature?

Hey guys

I am working on something similar right now, my project is authorize.net CIM-specific but I have already done a lot of work on the subscription manager code. I just came across this thread now so I will go through the patches and see what I may be able to contribute.

Cheers
Dave

I applied most of the patch applicable to uc_recurring_subscription, so these attachments are pretty up to date. I just attached uc_recurring_subscription.admin.inc and uc_recurring_subscription.module rather than patches because the changes are pretty extensive. At this point the following things are outstanding, and I am sure there are some improvements that can be made to the other parts of the code:

1) Deleting an option (I'm thinking it is probably better to use checkboxes than inline AJAX delete buttons, simply because it's easier to handle in the submit function).

2) Adding the role subscriptions. It's mentioned in this thread that this should be done with Rules rather than CA, but I'm not sure I follow the logic. uc_roles already handles this so isn't it simply a case of adding the entries to the relevant tables (uc_roles_products, others?).

- Dave

I'm trying to process a Recurring Product using the PayPal Sandbox using the latest 7x dev version. I'm getting these errors:

Am I getting these notices because of a misconfiguration on my end or because I'm using the sandbox?

The log shows that IPN transactions were received and verified.

Notice: Undefined property: stdClass::$order_product_id in uc_recurring_product_process_order() (line 370 of /home/compass/public_html/subdomains/beta.compassiontea.com/sites/all/modules/uc_recurring/modules/uc_recurring_product/uc_recurring_product.module).
Notice: Undefined index: amount in uc_recurring_hosted_paypal_wpp_process() (line 824 of /home/compass/public_html/subdomains/beta.compassiontea.com/sites/all/modules/uc_recurring/modules/uc_recurring_hosted/uc_recurring_hosted.module).
Notice: Undefined index: data in uc_recurring_hosted_paypal_wpp_process() (line 825 of /home/compass/public_html/subdomains/beta.compassiontea.com/sites/all/modules/uc_recurring/modules/uc_recurring_hosted/uc_recurring_hosted.module).
Notice: Undefined index: CURRENCYCODE in uc_recurring_hosted_paypal_wpp_process() (line 852 of /home/compass/public_html/subdomains/beta.compassiontea.com/sites/all/modules/uc_recurring/modules/uc_recurring_hosted/uc_recurring_hosted.module).
Notice: Undefined property: stdClass::$rfid in uc_recurring_hosted_paypal_wpp_process() (line 865 of /home/compass/public_html/subdomains/beta.compassiontea.com/sites/all/modules/uc_recurring/modules/uc_recurring_hosted/uc_recurring_hosted.module).
Notice: Undefined index: TRANSACTIONID in uc_recurring_hosted_paypal_wpp_process() (line 878 of /home/compass/public_html/subdomains/beta.compassiontea.com/sites/all/modules/uc_recurring/modules/uc_recurring_hosted/uc_recurring_hosted.module).
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'txn_id' cannot be null: INSERT INTO {uc_payment_paypal_ipn} (order_id, txn_id, txn_type, mc_gross, status, receiver_email, payer_email, received) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7); Array ( [:db_insert_placeholder_0] => 14 [:db_insert_placeholder_1] => [:db_insert_placeholder_2] => web_accept [:db_insert_placeholder_3] => [:db_insert_placeholder_4] => Completed [:db_insert_placeholder_5] => [:db_insert_placeholder_6] => rcharamella@gmail.com [:db_insert_placeholder_7] => 1317753695 ) in uc_recurring_hosted_paypal_wpp_process() (line 886 of /home/compass/public_html/subdomains/beta.compassiontea.com/sites/all/modules/uc_recurring/modules/uc_recurring_hosted/uc_recurring_hosted.module).

@univate:

I am working with Dave the Brave on this for a site. Here's a small set of followup patches. More will be on the way later.

I finished translating the CA to Rules for the base uc_recurring stuff as well, but since I haven't tested whether it works or not I'm leaving it out of the patch bundle for the moment.

bdragon. Thanks a ton for this. That's super helpful and hopefully it all gets merged.

Do you have a patch for the rules to test against? I have a big deliverable for next wednesday and would be happy to try them out on my dev box to confirm.

!!!WIP PATCH, NOT FOR COMMIT!!!

@rickmanelius: Here you go. I don't guarantee that it works at all, since I am unable to test it currently.

Back to the normal patch series...

* Fix a crapload of issues with the .install files.

Definitely going to need to commit something to the dev branch at some point. It's getting hard to track all the patches... :)

Yup. I just found that out as I was dealing with an SSL caching issue that was pointing to an old version. My apologies.

Does the current state of this module work with paypal? I get this error on the "review order" page, even after applying all patches 0001-0005

Notice: Undefined index: parameters in uc_recurring_hosted_form_uc_paypal_wps_form_alter() (line 578 of /public_html/sites/all/modules/uc_recurring/modules/uc_recurring_hosted/uc_recurring_hosted.module).

Is there an estimated date of completion for the uc_recurring_subscriptions feature? I did a fresh download and install, noting the 10/25 last update, and am still getting all the undefined errors when trying to add or update subscriptions. Thank you.

Hey.
Just installede the updates from #46.
and it solved most of the problem on admin inc.
But after that im getting this message:
Fatal error: Cannot use offset as an array in /var/www/thepetshop.dk/public_html/sites/all/moduls/uc_recuring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc on line 150

Im not a PHP master, and new to Drupal, can anyone help me with this, hope im posting the correct place.

Sincerely
Mikkel12

I'm also having the following error message on the 'cart/checkout/review' page:

Notice: Undefined index: parameters in uc_recurring_hosted_form_uc_paypal_wps_form_alter() (line 578 of /public_html/sites/all/modules/uc_recurring/modules/uc_recurring_hosted/uc_recurring_hosted.module)

I printed the variables array for the checkout review page and there is no ['#parameters']. So I edited line 578 of the uc_recurring_hosted module. Instead of:
$order = $form['#parameters'][2];
I now have:
$order = $form;

Everything seems to be working fine, the test payment went through without any errors. I'm still learning PHP/Drupal so could you please let me know if removing that is ok or was ['#parameters'][2] needed for the Paypal WPS process?

Thnx,
Mary

Correct me if I'm wrong, but it appears that there is still a bunch of work to do here before we have a working port.

#1400196: Fixes for Paypal recurring fees handler (uc_recurring_hosted)
#1380694: Notice: Undefined index: #parameters Error at checkout
#1308786: nonexistent criteria in uc_recurring_hosted_paypal_wpp_profile_creation_form_submit; compounding fees on missed payments
#1042262: Port uc_recurring to Rules instead of CA

All need to be integrated into the current alpha release. I have found a number of other problems while trying to work through my subscription workflow as well but the real big outstanding issue I see here is the CA -> Rules work.

I believe there has been some progress with CA -> Rules, but there appears to be nothing in the code? I am willing to write this code as I need to get things working, but my understanding from the above comments was that perhaps some of this was already done. Is it possible to have access to whatever has been done so far?

Found some rules code in #51. I will work off of this.

Ok, that sounds reasonable regarding the Paypal gateway issues.

What about subscriptions? In the 7.x-2.x branch, there is no subscriptions rules implementation and a number of problems with it. The patch in #51 does provide a rules implementation for subscriptions and so far it appears to be working for me. Shall I open another issue for Subscription CA -> Rules? This one is related #1355396: Error on Checkout and no Role Assigned.

@rcharamella I'm using latest dev and getting very similar errors to your #47. DId you resolve them eventually?

ubercart is really bullshet, I spend few weeks designing my website on drupal 7, finally at the subscription point ubercart links are broken for drupal 7, now i have to chose another method...

after 2 years everybody had this problem and still not solved,,,,,

these are my error;

Notice: Trying to get property of non-object in _uc_recurring_subscription_add_interval_form() (line 509 of /hermes/bosweb25c/b1205/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: default_option in _uc_recurring_subscription_add_interval_form() (line 516 of /hermes/bosweb25c/b1205/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc