While building UI Patterns 2, we have overridden or played around many core mechanisms. Let's maintain a list of those, in order to move them to Core one day.
| UI Patterns implementation | Core issue |
|---|---|
| Already done | #3390712: Add component variants to SDC |
| Already done | Issue to create: Add tags property |
| Already done | Issue to create: Add links property |
| #3481491: [2.0.x] Make components metadata translatable | #3493076: Props have no (translatable) labels |
| #3455354: [2.0.0-beta4] Add a stories specific discovery | Issue to create once #3464909: Collaboration with UI Patterns 2 is done |
Former subject: #3390717: Allow declaration of template path in SDC > we don't need it any more
| UI Patterns implementation | Core issue |
|---|---|
| Not applicable | #3390712: Add component variants to SDC and #3474533: ComponentPluginManager must implement CategorizingPluginManagerInterface (an emergency in order to fix #3469808: [2.0.0-beta5] Use decorator instead overwriting the component plugin service ) |
| Stuff in SchemaManager | #3352063: Allow schema references in Single Directory Component prop schemas |
| Issue to create? | #3391978: SDC: Add a method to retrieve only components not replaced by others |
| #3455354: [2.0.0-beta4] Add a stories specific discovery | #3475153: Make DirectoryWithMetadataDiscovery generic and reusable |
| UI Patterns implementation | Core issue |
|---|---|
| Some mess in NumberWidget::settingsForm() | #3554720: Remove addition of a object type in all props |
| Big mess in LinksPropType::normalize() | #3474528: Add unified Links data type for menus, pagers, breadcrumbs... |
| UI Patterns implementation | Core issue |
|---|---|
| Removed because Core issue was merged | #3391702: SDC ComponentElement: Transform slots scalar values to #plain_text instead of throwing an exception |
| #3383544: [2.0.0-beta5] Empty field values when not renderable | #3425818: SDC: Make empty render arrays evaluate to false in component templates |
| Logic in SlotPropType::normalize() | Issue to create: convertObject & normalizing arrays to be compatible with is sequence` and `is mapping `tests |
ComponentElementAlter::alter()
| Issue to create: SDC Validator is sometimes confused by a null slot or an empty slot |
ComponentElementAlter::processAttributesRenderProperty()
| #3515506: Process #attributes render property for SDCs |
SlotPropType::convertObject()
| #3504477: Allow all Renderable values in SDC slots |
| UI Patterns implementation | Core SDC issue |
|---|---|
| Not applicable | #3457874: HTML attributes as Twig mappings instead of PHP objects |
TwigExtension::addClass() and TwigExtension::setAttribute()
| #3354683: Decide how Twig filters should process against an array of render arrays |
| #3449653: [2.0.0-beta5] Replace component() function by native include() function | #3484580: Trigger SDC render element when using Twig include or embed |
| Not implemented | #3445425: \Drupal\Core\Template\Attribute should implement Countable interface (we hope it will allow {% if attributes %}) |
SDC & Form API
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
pdureau commentedComment #3
pdureau commentedComment #4
pdureau commentedComment #5
pdureau commentedComment #6
pdureau commentedComment #7
pdureau commentedComment #8
pdureau commentedComment #9
pdureau commentedComment #10
pdureau commentedComment #11
pdureau commentedComment #12
pdureau commentedComment #13
pdureau commentedComment #14
pdureau commentedComment #15
pdureau commentedComment #16
pdureau commentedComment #17
pdureau commentedComment #18
pdureau commentedComment #19
pdureau commentedComment #20
pdureau commentedComment #21
pdureau commentedComment #22
pdureau commentedDrupalCon chat with Wim. Let's check is something must be done in Core according to what we already do in UIP2:
The Core subject where we can help:
Also, let's check this if it is OK on UIP2 side:
Comment #23
wim leers#22 is the result of @pdureau and I going over #3462705: [META] Missing features in SDC needed for XB 😊
Comment #24
pdureau commentedComment #25
wim leersFYI: #3365985: Promote justinrainbow/json-schema from dev-dependency to full dependency blocks #3352063: Allow schema references in Single Directory Component prop schemas — do you want to add that explicitly, too?
Comment #26
pdureau commentedInteresting. Also, I am proposing in this XB issue https://www.drupal.org/project/experience_builder/issues/3515074#comment... to move 2 UIP2 service to Core: they may be useful for XB too, they are inspired from a Python library, they don't depend on anything related to UI Patterns, and they implement pure JSON schema logic.
Comment #27
pdureau commentedComment #29
pdureau commentedComment #30
pdureau commentedComment #31
pdureau commentedTODO: Remove #3567610: Adopt Core's stream wrapper additions once merged