Some of our form classes are injecting the Messenger service. This is not needed since the FormBase class uses the MessengerTrait so the messenger is already available.
::__construct() and ::create().$this->messenger property accesses with $this->messenger() method calls.Affected forms:
ContactFormEventInstanceDeleteFormEventInstanceFormEventInstanceRevisionDeleteFormEventInstanceRevisionRevertFormEventInstanceTypeFormEventSeriesDeleteFormEventSeriesFormEventSeriesRevisionDeleteFormEventSeriesRevisionRevertFormEventSeriesTypeDeleteFormEventSeriesTypeFormExcludedDatesDeleteFormExcludedDatesFormIncludedDatesDeleteFormIncludedDatesFormRegistrantDeleteFormRegistrantFormRegistrantResendFormRegistrantTypeFormSince this requires a change to the class constructor this affects B/C compatibility with code that might subclass our forms. Because of this, this can only be done in the 3.x branch.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
pfrenssenComment #3
sayan_k_dutta commentedWorking on it.
Comment #5
sayan_k_dutta commentedRemoved all the messenger services injection from the Form classes. Created MR!118. Please check it.
Comment #6
sayan_k_dutta commentedComment #7
pfrenssenLooking great, 300+ lines of unnecessary code are removed! Thanks a lot for working on this!
Comment #9
pfrenssenNo idea why the merging script decided to put my name first in the commit message :-/ I only changed one line while @sayan_k_dutta did ALL of the work.
Anyway thanks a lot for fixing this so quickly!