Provide details of where core tests, not in core modules, should live.

Novice issue reserved for the Mentored Contribution during DrupalCon Barcelona 2024. After the 27th of September 2024, this issue returns to being open to all. Thanks

Look at this commit
https://git.drupalcode.org/project/drupal/-/commit/c70620dc49df2ca821857...

and write similar guidance about where core tests(not in modules) should be located.

Is the following correct for core lib tests?

• Unit tests: core/lib/tests/Drupal/Tests/Core (Drupal\Tests\Core\)
• Kernel tests: core/lib/tests/Drupal/KernelTests/ (Drupal\KernelTests\Core\)
• Functional tests: core/lib/tests/Drupal/FunctionalTests/ (Drupal\FunctionalTests\Core\)
• Functional Javascript tests: core/lib/tests/Drupal/FunctionalJavascriptTests/ (Drupal\FunctionalJavascriptTests\Core\)
• Build tests: core/lib/tests/Drupal/BuildTests (Drupal\BuildTests)
• Test site tests: core/lib/tests/Drupal/TestSite (Drupal\TestSite)
• Test tools tests: core/lib/tests/Drupal/TestTools (Drupal\TestTools)
• Nightwatch tests: core/lib/tests/Drupal/Nightwatch

-mike

@ultimike if by core lib tests you mean testing things in core/lib/Drupal/Core then yes. Things are a bit messy though. \Drupal\FunctionalJavascriptTests\Ajax\AjaxCallbacksTest is testing core stuff for example. And \Drupal\FunctionalJavascriptTests\Components\ComponentRenderTest is not about core/lib/Drupal/Component

The unit test directory is probably the most sorted... where tests for core/lib/Drupal/Core live in core/tests/Drupal/Tests/Core and tests for core/lib/Drupal/Component live in core/tests/Drupal/Tests/Component

Tests are passing. Needs review.

-mike

Looks good to me.

Requeued tests, added question about another possible enhancement we could add here

Thank you @larowlan & @smustgrave for your comments.

I rebased on 11.x and added missing part for contrib modules in BuildTestBase class.

Moving issue to Needs review.

I'm sorry, I don't know why functional tests do not pass.
As an example : Drupal\Tests\layout_builder\Functional\LayoutSection gives following error :

Layout section formatter access
       ┐
       ├ Behat\Mink\Exception\ResponseTextException: The text "Hello test world" was not found anywhere in the text of the current page.

As it does not relates on this issue, I don't know how to get the whole test pipeline work.

@mattlc, thanks for rebasing this. Some of the tests often fail randomly, and this is what you have encountered. We keep track of the random fails and in this issue, #2829040: [meta] Known intermittent, random, and environment-specific test failures. That is where anyone who wants to the challenge of fixing a randomly failing test can find one to work on.

I have restarted the failing tests and they have come back passing this time. You should also be able to restart the tests using the GitLab UI.

Spotted one problem with existing docs right next to the ones we're adding in core/tests/Drupal/Tests/UnitTestCase.php. Should we fix those here or in a follow-up?

I should have added: the new docs look great! Big improvement. Thanks for working on this!

Fixed #14 (& #15). CI is running.

Committed 6025a14 and pushed to 11.x. Thanks!
Committed f54e0fc and pushed to 11.1.x. Thanks!