The right padding is not enough when using Admin Toolbar with Gin theme.

CommentFileSizeAuthor
#9 after-applying-patch-8-horizontal-modern-toolbar.png37.39 KBVidushi Mehta
#9 after-applying-patch-8-classic-drupal-toolbar.png51.4 KBVidushi Mehta
#9 after-applying-patch-7-horizontal-modern-toolbar.png39.7 KBVidushi Mehta
#9 after-applying-patch-7-classic-drupal-toolbar.png37.99 KBVidushi Mehta
#8 Gin-issue-with-tablet-screen.png76.71 KBmukeysh
#8 3368814-8.patch1.04 KBmukeysh
#7 after-3368814-7-patch.png129.17 KBlokeshsahu
#7 interdiff_1-7.txt1.28 KBlokeshsahu
#7 3368814-7.patch1.16 KBlokeshsahu
#5 Screenshot 2023-06-23 at 12.28.30 PM.png179.08 KBlokeshsahu
#2 Gin.png125.68 KBmukeysh
#2 3368814-1.patch417 bytesmukeysh
gin-toolbar-right-padding.png65.13 KBloran@xpor.org

Comments

loran@xpor.org created an issue. See original summary.

mukeysh’s picture

mukeysh commented
StatusFileSize
new 3368814-1.patch417 bytes
new Gin.png125.68 KB

Applying a patch to fix the above issue. Also attaching a screenshot for reference.

mukeysh’s picture

mukeysh commented
Status: Active » Needs review
Vidushi Mehta’s picture

Vidushi Mehta commented
Status: Needs review » Needs work
StatusFileSize
new gin-toolbar-menu-and -arrow-overlap.png21.79 KB

@Mukeysh tested your patch, this issue is still not resolved. Added screenshot for the same.

lokeshsahu’s picture

lokeshsahu commented
StatusFileSize
new Screenshot 2023-06-23 at 12.28.30 PM.png179.08 KB

I tried to reproduce and fix the above-addressed issue with the help of the #2 patch. The patch was applied successfully without throwing any error but the issue still exists as the patch only has the changes in the source file (SCSS) and no changes on the destination file (CSS). Attaching a screenshot after applying the patch for reference. Issue still exists.

Vidushi Mehta’s picture

Vidushi Mehta commented

Yeah, Need to include the css file in the patch but I've compiled this on my local after applying the patch but the issue still persist
@lokeshsahu, the screenshot which you have deleted is only after compiling the code.

lokeshsahu’s picture

lokeshsahu commented
Status: Needs work » Needs review
StatusFileSize
new 3368814-7.patch1.16 KB
new interdiff_1-7.txt1.28 KB
new after-3368814-7-patch.png129.17 KB

I have created another patch to address the above issue as the #1 patch couldn't fix the raised issue. I am attaching a screenshot for reference, showing the state before and after applying the patch and a interdiff file for reference.

mukeysh’s picture

mukeysh commented
StatusFileSize
new 3368814-8.patch1.04 KB
new Gin-issue-with-tablet-screen.png76.71 KB

The above patch working fine but only for the Legacy, Classic Drupal Toolbar not for the Horizontal, Modern Toolbar. Also, there is also some issue with the tablet screen. Attaching a screenshot for reference.

Adding patch with changes.

Vidushi Mehta’s picture

Vidushi Mehta commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after-applying-patch-7-classic-drupal-toolbar.png37.99 KB
new after-applying-patch-7-horizontal-modern-toolbar.png39.7 KB
new after-applying-patch-8-classic-drupal-toolbar.png51.4 KB
new after-applying-patch-8-horizontal-modern-toolbar.png37.39 KB

I've reviewed both the patches ( #7 and #8 ) and verified that #8 resolved the issue. Added the screenshots of after applying both the patches for more clarity.

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks y'all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.