Problem/Motivation

In #3187857: [Symfony 6] Service deprecation messages require more fields we added code to support two different method signatures for Symfony\Component\DependencyInjection\Definition - this allows Drupal 9 to run on Symfony 5 (after a manual compuser update) without changes.

In Drupal 10 we'll require Symfony 5 or higher, so can drop the compatibility layer for Symfony 4.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3197729

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Parent issue: » #3161889: [META] Symfony 6 compatibility
andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3197483: Evaluate the potential update of Drupal 10 to Symfony 6 and do it if possible
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
Status: Postponed » Needs work

Unpostponing since there's now a Drupal 10.0.x-dev branch

spokje’s picture

spokje
Primary language Dutch
commented

Unpostponing since there's now a Drupal 10.0.x-dev branch

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Needs work » Postponed

No, re-postponing, since the current 10.0.x-dev is on 

        {
            "name": "symfony/dependency-injection",
            "version": "v4.4.34",
            "source": {
                "type": "git",
                "url": "https://github.com/symfony/dependency-injection.git",
                "reference": "117d7f132ed7efbd535ec947709d49bec1b9d24b"
            },
daffie’s picture

daffie commented
Status: Postponed » Active

#3197482: Update Drupal 10 to depend on Symfony 5.4 (as a stepping stone to Symfony 6, for deprecation checking support) has landed.

Spokje opened merge request !1661

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Looks OK to me.

Could do with a followup to remove the cache.null service as per https://www.drupal.org/node/3066407 if an issue for this doesn't exist already.

spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3258918: Remove deprecated 'cache.null' service

Thanks @longwave, couldn't find an issue for the removal of the cache.null service, so created a follow-up: #3258918: Remove deprecated 'cache.null' service

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 6923e5e and pushed to 10.0.x. Thanks!

  • alexpott committed 6923e5e on 10.0.x 
    Issue #3197729 by Spokje: Remove forward/bc layer for Symfony Definition...

Spokje closed merge request !1661

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.