ERR in nested IEF loses Refs

@geek-merlin,

So, I tested and this is a good start. I see it's basically my approach :)

IMO the PR could be cleaned up a bit for things like doc blocks, coding standards and I think the updater could be a service? Anyway, these are minor, I can make a patch for these. I conform this works also with 3 levels.

But we have more important problems.

On a fresh install it works. However, if the main node is translatable (Page from the description) AND the reference field from Page to Article is NOT translatable AND there is a moderation workflow on Page, we have the same problem. Took me a long time to reproduce. And turns out, if you then disable the workflow on the CT, it will still fail. So once enabled, it will fail even after disabling.

I have no idea why but the symptom is that when the form is submitted, the entire reference is gone from the entity that is found in the inline_entity_form form_state, so the updater no longer can compare the target_ids to update the reference with the saved revision.

Please let me know if you can reproduce.

Just as an update, the content moderation part of the reproduction is finicky. Try with it and without it and see. On a different installation, it worked also with a workflow on it. But it may be a coincidence caused by something else. Super difficult to tell what is happening.

Hi, just a follow up on the issue.

I am curious why the error gets triggered based on the existence of the entity id.
If you e.g. prevent saving an entity in the first place for whatever reason, the entity won't get an id - but with the logic applied registerEntity will throw an error in ReferenceUpgrader.php:

public function registerEntity(EntityInterface $entity) {
  $entityId = $entity->id() ?? $this->throwNeedsId();
  $this->entities[$entity->getEntityTypeId()][$entityId] = $entity;
}

And the Method is also triggered as a kind of "post" save method after the original save of the entity (which also might prevent an entity from being saved at all) in WidgetSubmit.php:

$referenceUpgrader->upgradeEntityReferences($entity);
$handler->save($entity);
$referenceUpgrader->registerEntity($entity);

Idd. This also seems the reason why I'm getting a fatal error when you submit the node form, without first saving the inline entity form.