Problem/Motivation
While adding the first tests to Bricks, schema had to been added in #3009000-14: Write config schema.
field.formatter.settings.bricks_nested:
- type: field.formatter.settings.entity_reference_entity_view
+ type: field.formatter.settings.entity_reference_revisions_entity_view
That shows the dependency.
In #3068108: BricksFieldTypeTrait should be in bricks, not brick_revisions, so can be used in BricksTreeItem we added a test for bricks, without bricks_revision, that needed to use entity_reference_revisions to pass.
Proposed resolution
a) Check how we can avoid the dependency on entity_reference_revisions
or
b) Make the dependency to entity_reference_revisions explicit in bricks.info.yml and composer.json
Remaining tasks
Discuss.
User interface changes
API changes
Data model changes
Release notes snippet
Comments
Comment #2
penyaskitoNot sure how, but looks like that change was not really needed? I'm confused now.
However, this patch runs with
*
\Drupal\Tests\bricks\Kernel\BricksTest*
\Drupal\Tests\bricks\Functional\BricksTest*
\Drupal\Tests\lingotek\Functional\LingotekNodeEmbeddingBricksTranslationTestSo must be good
Comment #4
ghost of drupal pastIf it works, it works. Let it be.