symfony/dependency-injection": "~2.8"

The symfony/dependency-injection ~2.8 requirement has never been updated and conflicts with the drupal/core symfony ~3.2 and ^3.2 requirements.

Changing to ~2.8|~3.0 is the hot fix that would keep a composer merge happy but is this component actually compatible with both symfony/dependency-injection 2.8 and 3.2? Perhaps we can deduce a higher minimum version requirement by looking at the git logs. (or by just looking at all the code if you're a symfony expert)

CommentFileSizeAuthor
#8 2876671_8.patch609 bytesMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Eric_A created an issue. See original summary.

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Issue summary: View changes
Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Related issues: +#2867960: Merge Component composer.json files to account for them during build
Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Title: Fix symfony version requirement for drupal/core-dependency-injection » Fix symfony/dependency-injection ~2.8 requirement for drupal/core-dependency-injection
Issue summary: View changes
Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Title: Fix symfony/dependency-injection ~2.8 requirement for drupal/core-dependency-injection » Fix symfony/dependency-injection ~2.8 requirement in drupal/core-dependency-injection
Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Issue summary: View changes

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Version: 8.5.x-dev » 8.4.x-dev
Category: Task » Bug report
Status: Active » Needs review
FileSize
2876671_8.patch609 bytes

In order to figure out how to be consistent in fixing this, I forked drupal/core-dependency: https://github.com/paul-m/core-dependency-injection/tree/8.4.x

I added some travis magic here: https://travis-ci.org/paul-m/core-dependency-injection

In order to get a passing test I had to make these changes: https://github.com/paul-m/core-dependency-injection/commit/0e2e0c591b65a...

In order to evaluate all this you can concentrate on the composer.json file. drupal/core-dependency-injection actually needs drupal/core-utility. And since the test includes composer install --prefer-lowest, we learn that drupal/core-dependency-injection can work with symfony/dependency-injection 3.0.0.

This is actually a bug because there's no way to use only drupal/core-dependency-injection until this is fixed: http://cgit.drupalcode.org/drupal/tree/core/lib/Drupal/Component/Depende...

Status: Needs review » Needs work

The last submitted patch, 8: 2876671_8.patch, failed testing. View results

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Closed (outdated)
Issue tags: +Bug Smash Initiative

Not sure which issue made this particular fix but the composer.json has been updated quite a few times since 2017. Drupal 8.9.x is on "symfony/dependency-injection": "~3.4.26".

Closing as outdated.