Remove rest.module BC layers

This removes all BC layers from core/modules/rest as of July 11, 2017, commit e1e216138f5311a5dd6b96b5789ab2db9ac5fd5f.

(Note that this must be applied on top of #2893795-2: Remove serialization.module BC layers.)

 core/modules/rest/config/install/rest.settings.yml |   7 -
 core/modules/rest/config/schema/rest.schema.yml    |  14 -
 core/modules/rest/rest.api.php                     |  57 --
 core/modules/rest/rest.install                     |  60 --
 core/modules/rest/rest.post_update.php             |  63 ---
 core/modules/rest/rest.routing.yml                 |   9 -
 core/modules/rest/rest.services.yml                |  15 -
 .../src/EventSubscriber/RestConfigSubscriber.php   |  53 --
 .../ConfigurableLinkManagerInterface.php           |  13 -
 core/modules/rest/src/LinkManager/LinkManager.php  |  13 -
 .../rest/src/LinkManager/LinkManagerBase.php       |  13 -
 .../rest/src/LinkManager/LinkManagerInterface.php  |  13 -
 .../rest/src/LinkManager/RelationLinkManager.php   |  13 -
 .../LinkManager/RelationLinkManagerInterface.php   |  13 -
 .../rest/src/LinkManager/TypeLinkManager.php       |  13 -
 .../src/LinkManager/TypeLinkManagerInterface.php   |  13 -
 .../PathProcessorEntityResourceBC.php              |  55 --
 core/modules/rest/src/Plugin/ResourceBase.php      |   8 -
 .../src/Plugin/rest/resource/EntityResource.php    |  10 +-
 core/modules/rest/src/RestServiceProvider.php      |  51 --
 core/modules/rest/src/Tests/RESTTestBase.php       | 624 ---------------------
 .../Update/EntityResourcePermissionsUpdateTest.php |  56 --
 .../Tests/Update/ResourceGranularityUpdateTest.php |  71 ---
 .../Update/RestConfigurationEntitiesUpdateTest.php |  65 ---
 .../src/Tests/Update/RestExportAuthUpdateTest.php  |  36 --
 ....rest-rest_post_update_resource_granularity.php | Bin 5199 -> 0 bytes
 .../update/drupal-8.rest-rest_update_8201.php      |  59 --
 .../update/drupal-8.rest-rest_update_8203.php      |  58 --
 .../update/rest-export-with-authentication.php     |  65 ---
 .../rest.resource.entity.comment_2721595.yml       |  32 --
 .../update/rest.resource.entity.node_2721595.yml   |  29 -
 .../update/rest.resource.entity.user_2721595.yml   |  32 --
 .../BcTimestampNormalizerUnixTestTrait.php         |  43 --
 .../BaseFieldOverrideResourceTestBase.php          |   4 -
 .../EntityResource/Block/BlockResourceTestBase.php |   4 -
 .../Comment/CommentResourceTestBase.php            |  17 +-
 .../Editor/EditorResourceTestBase.php              |   4 -
 .../EntityResource/EntityResourceTestBase.php      | 171 ------
 .../EntityTest/EntityTestResourceTestBase.php      |  12 +-
 .../EntityTestLabelResourceTestBase.php            |  12 +-
 .../EntityResource/Feed/FeedResourceTestBase.php   |  22 +-
 .../FieldConfig/FieldConfigResourceTestBase.php    |   4 -
 .../FieldStorageConfigResourceTestBase.php         |   4 -
 .../ImageStyle/ImageStyleResourceTestBase.php      |   4 -
 .../EntityResource/Item/ItemResourceTestBase.php   |  12 +-
 .../MenuLinkContentResourceTestBase.php            |  12 +-
 .../EntityResource/Node/NodeResourceTestBase.php   |  22 +-
 .../NodeType/NodeTypeResourceTestBase.php          |   4 -
 .../SearchPage/SearchPageResourceTestBase.php      |   4 -
 .../Shortcut/ShortcutResourceTestBase.php          |   4 -
 .../EntityResource/Term/TermResourceTestBase.php   |  12 +-
 .../EntityResource/Tour/TourResourceTestBase.php   |   4 -
 .../EntityResource/User/UserResourceTestBase.php   |  17 +-
 53 files changed, 62 insertions(+), 1963 deletions(-)

(This module likely has the most BC layers and the most BC layer test coverage of all of core I think, considering how much we can remove…)

Rebased for 8.5.x, commit 0fa72bdeea3d72e874b25dc72d2185645b57d6c5.

Updating for BC layers added to #2720233: Use arguments resolver in RequestHandler to have consistent parameter ordering.

Slightly bigger diffstat now:

 core/modules/rest/config/install/rest.settings.yml |   7 -
 core/modules/rest/config/schema/rest.schema.yml    |  14 -
 core/modules/rest/rest.api.php                     |  57 --
 core/modules/rest/rest.install                     |  60 --
 core/modules/rest/rest.post_update.php             |  63 ---
 core/modules/rest/rest.routing.yml                 |   9 -
 core/modules/rest/rest.services.yml                |  15 -
 .../src/EventSubscriber/RestConfigSubscriber.php   |  53 --
 .../ConfigurableLinkManagerInterface.php           |  13 -
 core/modules/rest/src/LinkManager/LinkManager.php  |  13 -
 .../rest/src/LinkManager/LinkManagerBase.php       |  13 -
 .../rest/src/LinkManager/LinkManagerInterface.php  |  13 -
 .../rest/src/LinkManager/RelationLinkManager.php   |  13 -
 .../LinkManager/RelationLinkManagerInterface.php   |  13 -
 .../rest/src/LinkManager/TypeLinkManager.php       |  13 -
 .../src/LinkManager/TypeLinkManagerInterface.php   |  13 -
 .../PathProcessorEntityResourceBC.php              |  55 --
 core/modules/rest/src/Plugin/ResourceBase.php      |   8 -
 .../src/Plugin/rest/resource/EntityResource.php    |  10 +-
 core/modules/rest/src/RequestHandler.php           |  41 +-
 core/modules/rest/src/RestServiceProvider.php      |  51 --
 core/modules/rest/src/Tests/RESTTestBase.php       | 624 ---------------------
 ....rest-rest_post_update_resource_granularity.php | Bin 5199 -> 0 bytes
 .../update/drupal-8.rest-rest_update_8201.php      |  59 --
 .../update/drupal-8.rest-rest_update_8203.php      |  58 --
 .../update/rest-export-with-authentication.php     |  65 ---
 .../rest.resource.entity.comment_2721595.yml       |  32 --
 .../update/rest.resource.entity.node_2721595.yml   |  29 -
 .../update/rest.resource.entity.user_2721595.yml   |  32 --
 .../BcTimestampNormalizerUnixTestTrait.php         |  43 --
 .../BaseFieldOverrideResourceTestBase.php          |   4 -
 .../EntityResource/Block/BlockResourceTestBase.php |   4 -
 .../Comment/CommentResourceTestBase.php            |  17 +-
 .../Editor/EditorResourceTestBase.php              |   4 -
 .../EntityResource/EntityResourceTestBase.php      | 171 ------
 .../EntityTest/EntityTestResourceTestBase.php      |  12 +-
 .../EntityTestLabelResourceTestBase.php            |  12 +-
 .../EntityResource/Feed/FeedResourceTestBase.php   |  22 +-
 .../FieldConfig/FieldConfigResourceTestBase.php    |   4 -
 .../FieldStorageConfigResourceTestBase.php         |   4 -
 .../ImageStyle/ImageStyleResourceTestBase.php      |   4 -
 .../EntityResource/Item/ItemResourceTestBase.php   |  12 +-
 .../MenuLinkContentResourceTestBase.php            |  12 +-
 .../EntityResource/Node/NodeResourceTestBase.php   |  22 +-
 .../NodeType/NodeTypeResourceTestBase.php          |   4 -
 .../SearchPage/SearchPageResourceTestBase.php      |   4 -
 .../Shortcut/ShortcutResourceTestBase.php          |   4 -
 .../EntityResource/Term/TermResourceTestBase.php   |  12 +-
 .../EntityResource/Tour/TourResourceTestBase.php   |   4 -
 .../EntityResource/User/UserResourceTestBase.php   |  17 +-
 .../Update/EntityResourcePermissionsUpdateTest.php |  56 --
 .../Update/ResourceGranularityUpdateTest.php       |  71 ---
 .../Update/RestConfigurationEntitiesUpdateTest.php |  65 ---
 .../Functional/Update/RestExportAuthUpdateTest.php |  36 --
 54 files changed, 63 insertions(+), 2003 deletions(-)

Updating for BC layers added in #2825204: REST views: authentication is broken. Which added a whole bunch of BC layer/update path code that can be removed. ~180 additional line deletions:

 core/modules/rest/config/install/rest.settings.yml |   7 -
 core/modules/rest/config/schema/rest.schema.yml    |  14 -
 core/modules/rest/rest.api.php                     |  57 --
 core/modules/rest/rest.install                     |  96 ----
 core/modules/rest/rest.module                      |  27 -
 core/modules/rest/rest.post_update.php             |  63 ---
 core/modules/rest/rest.routing.yml                 |   9 -
 core/modules/rest/rest.services.yml                |  15 -
 .../src/EventSubscriber/RestConfigSubscriber.php   |  53 --
 .../ConfigurableLinkManagerInterface.php           |  13 -
 core/modules/rest/src/LinkManager/LinkManager.php  |  13 -
 .../rest/src/LinkManager/LinkManagerBase.php       |  13 -
 .../rest/src/LinkManager/LinkManagerInterface.php  |  13 -
 .../rest/src/LinkManager/RelationLinkManager.php   |  13 -
 .../LinkManager/RelationLinkManagerInterface.php   |  13 -
 .../rest/src/LinkManager/TypeLinkManager.php       |  13 -
 .../src/LinkManager/TypeLinkManagerInterface.php   |  13 -
 .../PathProcessorEntityResourceBC.php              |  55 --
 core/modules/rest/src/Plugin/ResourceBase.php      |   8 -
 .../src/Plugin/rest/resource/EntityResource.php    |  10 +-
 .../rest/src/Plugin/views/display/RestExport.php   |  18 -
 core/modules/rest/src/RequestHandler.php           |  41 +-
 core/modules/rest/src/RestServiceProvider.php      |  51 --
 core/modules/rest/src/Tests/RESTTestBase.php       | 626 ---------------------
 .../Update/RestExportAuthCorrectionUpdateTest.php  |  36 --
 ....rest-rest_post_update_resource_granularity.php | Bin 5199 -> 0 bytes
 .../update/drupal-8.rest-rest_update_8201.php      |  59 --
 .../update/drupal-8.rest-rest_update_8203.php      |  58 --
 .../rest-export-with-authentication-correction.php |  63 ---
 .../update/rest-export-with-authentication.php     |  65 ---
 .../rest.resource.entity.comment_2721595.yml       |  32 --
 .../update/rest.resource.entity.node_2721595.yml   |  29 -
 .../update/rest.resource.entity.user_2721595.yml   |  32 --
 .../BcTimestampNormalizerUnixTestTrait.php         |  43 --
 .../BaseFieldOverrideResourceTestBase.php          |   4 -
 .../EntityResource/Block/BlockResourceTestBase.php |   4 -
 .../Comment/CommentResourceTestBase.php            |  17 +-
 .../Editor/EditorResourceTestBase.php              |   4 -
 .../EntityResource/EntityResourceTestBase.php      | 174 ------
 .../EntityTest/EntityTestResourceTestBase.php      |  12 +-
 .../EntityTestLabelResourceTestBase.php            |  12 +-
 .../EntityResource/Feed/FeedResourceTestBase.php   |  22 +-
 .../FieldConfig/FieldConfigResourceTestBase.php    |   4 -
 .../FieldStorageConfigResourceTestBase.php         |   4 -
 .../ImageStyle/ImageStyleResourceTestBase.php      |   4 -
 .../EntityResource/Item/ItemResourceTestBase.php   |  12 +-
 .../MenuLinkContentResourceTestBase.php            |  12 +-
 .../EntityResource/Node/NodeResourceTestBase.php   |  22 +-
 .../NodeType/NodeTypeResourceTestBase.php          |   4 -
 .../SearchPage/SearchPageResourceTestBase.php      |   4 -
 .../Shortcut/ShortcutResourceTestBase.php          |   4 -
 .../EntityResource/Term/TermResourceTestBase.php   |  12 +-
 .../EntityResource/Tour/TourResourceTestBase.php   |   4 -
 .../EntityResource/User/UserResourceTestBase.php   |  17 +-
 .../Update/EntityResourcePermissionsUpdateTest.php |  56 --
 .../Update/ResourceGranularityUpdateTest.php       |  71 ---
 .../Update/RestConfigurationEntitiesUpdateTest.php |  65 ---
 .../Functional/Update/RestExportAuthUpdateTest.php |  36 --
 58 files changed, 63 insertions(+), 2188 deletions(-)

There have been quite a few REST changes lately. Patch didn't apply anymore.

Rebased on top of commit 91e668f5758159b27bea9e4bc3247969fa91232a, solved all conflicts. Because of removed whitespace, there are now fewer deletions:

58 files changed, 63 insertions(+), 2168 deletions(-)

Also: I should've been queueing tests for this, to prove that it works. Did that this time.

More REST tests have been added, I haven't updated them all perfectly, hence tests not being able to run.

5 more files changed:

 63 files changed, 79 insertions(+), 2182 deletions(-)

This should fix some of the failures.

Patch no longer applied, due to #2800873: Add XML GET REST test coverage, work around XML encoder quirks, #2905686: Expand EntityResourceTestBase to test PATCHing multi-value fields: both adding and removing items and #2765959: Make 4xx REST responses cacheable by (Dynamic) Page Cache + comprehensive cacheability test coverage landing since #9 was posted. Had to solve some conflicts.

#2765959: Make 4xx REST responses cacheable by (Dynamic) Page Cache + comprehensive cacheability test coverage added some extra code to ensure BC layers are respected by the support for caching responses:

+      // Add global rest settings config's cache tag, for BC flags.
+      // @see \Drupal\rest\Plugin\rest\resource\EntityResource::permissions()
+      // @see \Drupal\rest\EventSubscriber\RestConfigSubscriber
+      // @todo Remove in https://www.drupal.org/node/2893804
+      $response->addCacheableDependency($this->configFactory->get('rest.settings'));

(and more)

That can now all be removed too.

Diffstat keeps getting more appealing:

 68 files changed, 92 insertions(+), 2275 deletions(-)

error: cannot apply binary patch to 'core/modules/rest/tests/fixtures/update/drupal-8.rest-rest_post_update_resource_granularity.php' without full index line
error: core/modules/rest/tests/fixtures/update/drupal-8.rest-rest_post_update_resource_granularity.php: patch does not apply

I hate git diff --binary with a passion. A) git is stupid for thinking it's binary, B) why can't I configure git to always create binary patches!?

This patch is identical to 11, but with --binary.

Drupal\dblog\Tests\Rest\DbLogResourceTest fails with a fatal error, because it uses a deprecated base class that this patch is removing. Created #2927758: Update DbLogResourceTest to use the ResourceTestBase base class instead of the deprecated RESTTestBase to update that test to no longer use the deprecated base test class. That now blocks this patch from becoming green.

Same for ResponseGeneratorTest. Created #2927766: Update ResponseGeneratorTest to use the BrowserTestBase base class instead of the deprecated RESTTestBase for that.

Same for RestRegisterUserTest. Created #2927768: Update RestRegisterUserTest to use the ResourceTestBase base class instead of the deprecated RESTTestBase for that.

This is blocked on #13 + #14 + #15.

All remaining test failures except for the 3 listed in #13+#14+#15 are like this:

/usr/local/bin/php /private/var/folders/f6/g_q2g6w545z_q3h4cx7kv2qm0000gn/T/ide-phpunit.php --configuration /Users/wim.leers/Work/d8/core/phpunit.xml --filter "/::testSourceFeedRequired( .*)?$/" Drupal\Tests\aggregator\Functional\Update\AggregatorUpdateTest /Users/wim.leers/Work/d8/core/modules/aggregator/tests/src/Functional/Update/AggregatorUpdateTest.php
Testing started at 12:05 ...
#!/usr/bin/env php
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\aggregator\Functional\Update\AggregatorUpdateTest
F

Time: 36.9 seconds, Memory: 6.00MB

There was 1 failure:

1) Drupal\Tests\aggregator\Functional\Update\AggregatorUpdateTest::testSourceFeedRequired
No schema for rest.settings

/Users/wim.leers/Work/d8/core/tests/Drupal/Tests/SchemaCheckTestTrait.php:31
/Users/wim.leers/Work/d8/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php:372
/Users/wim.leers/Work/d8/core/modules/aggregator/tests/src/Functional/Update/AggregatorUpdateTest.php:34

FAILURES!
Tests: 1, Assertions: 251, Failures: 1.

Process finished with exit code 1

Interestingly, this only happens for update path tests. My guess: because the default installation of D8 that update path tests run against does contain rest.settings configuration.

If I restore just

rest.settings:
  type: config_object

then the error changes to:

Schema key rest.settings:resources failed with: missing schema

Which points to rest_update_8201() + rest_post_update_create_rest_resource_config_entities(). Sure enough, when I add rest_update_8201(), tests pass again. (Or at lest AggregatorUpdateTest does.) I searched and found the minimal work-around necessary for now.

Schema key rest.settings:bc_entity_resource_permissions failed with: missing schema

Looks like I literally have to restore the entire config schema.

This fixes the failures in EntitySerializationTest, Drupal\Tests\rest\Kernel\RequestHandlerTest and Drupal\Tests\rest\Functional\ResourceTest.

For the 3 remaining failures, see #13+#14+#15.

Current tally:

 69 files changed, 105 insertions(+), 2246 deletions(-)

#2927766: Update ResponseGeneratorTest to use the BrowserTestBase base class instead of the deprecated RESTTestBase landed. That still leaves #2927758: Update DbLogResourceTest to use the ResourceTestBase base class instead of the deprecated RESTTestBase + #2927768: Update RestRegisterUserTest to use the ResourceTestBase base class instead of the deprecated RESTTestBase.

#2927758: Update DbLogResourceTest to use the ResourceTestBase base class instead of the deprecated RESTTestBase is also in.

The failing RestExportAuthTest was effectively an update path test, without it being named that way. Deleted it, and its test view.

71 files changed, 105 insertions(+), 2518 deletions(-)

This no longer applied. Rebased. Solved dozens of conflicts.

Diffstat is still similar:

71 files changed, 103 insertions(+), 2491 deletions(-)

Per #2940417: Remove always_populate_raw_post_data requirements check, which might be incorrect, rest_requirements() can be removed as soon as Drupal doesn't support PHP 5.6 anymore. Drupal 9 won't support it. So, removing it.

71 files changed, 103 insertions(+), 2508 deletions(-)

(The lower number of lines removed is mostly due to RequestHandler and EntityResourceTestBase having been improved in HEAD!)

It's been ~5 months since I rerolled this patch, so I forgot how stupid git is again:

error: cannot apply binary patch to 'core/modules/rest/tests/fixtures/update/drupal-8.rest-rest_post_update_resource_granularity.php' without full index line

Rerolled #24 with --binary.

Fixed

00:00:53.818 PHP Fatal error:  Trait 'Drupal\Tests\rest\Functional\BcTimestampNormalizerUnixTestTrait' not found in /var/www/html/core/modules/rest/tests/src/Functional/EntityResource/File/FileResourceTestBase.php on line 12

New diffstat:

74 files changed, 119 insertions(+), 2523 deletions(-)

Yay, only 30 failures, not bad! Fixing some of the trivial failures.

No longer applies because #2910883: Move all entity type REST tests to the providing modules landed. Very painful rebase.

Rebase completed. Hopefully I didn't make too many mistakes.

 75 files changed, 150 insertions(+), 2536 deletions(-)

And while doing the rebase, I spotted a few things I missed in the REST tests that were added since #21/December last year.

More importantly, I again forgot to do #30 with --binary 🙃

With #2910883: Move all entity type REST tests to the providing modules committed, there now is again a whole lot of additional BC layer that needs to be removed! This interdiff does that.

 122 files changed, 150 insertions(+), 3284 deletions(-)

#2927768: Update RestRegisterUserTest to use the ResourceTestBase base class instead of the deprecated RESTTestBase landed!

_{#2927768: Update RestRegisterUserTest to use the ResourceTestBase base class instead of the deprecated RESTTestBase landed, so this is no longer postponed on anything except for the D9 branch being opened 🥳}

Nearly a year later, time for an update. Commit c8dc57eedea3fd34de067098ca2ee36e6c459245. Rebased #32. Next: removing any BC layers added since then.

 122 files changed, 150 insertions(+), 3311 deletions(-)

Done.

 130 files changed, 159 insertions(+), 3502 deletions(-)

Per #34.

Now that #3087874: [meta] Make 9.0.x branch pass testbot is done, let's do this!

To start us off: a rebase of #35.

Fixed phpcs violations.

😈 --binary

Some new tests were added since #35 in February, this removes BC layer logic from those as well.

This patch won't be green yet, but it'll be quite a bit closer.

😈 --binary

#49: Easy rebase for either one though! :)

Yay, #48 is down to 20 failures.

Most of the remaining failures are caused by a single removal of deprecated code, specifically:

-    // BC: the REST module originally created the POST URL for a resource by
-    // reading the 'https://www.drupal.org/link-relations/create' URI path from
-    // the plugin annotation. For consistency with entity type definitions, that
-    // then changed to reading the 'create' URI path. For any REST Resource
-    // plugins that were using the old mechanism, we continue to support that.
-    if (!isset($definition['uri_paths']['create']) && isset($definition['uri_paths']['https://www.drupal.org/link-relations/create'])) {
-      $create_path = $definition['uri_paths']['https://www.drupal.org/link-relations/create'];
-    }

… because the two @RestResource plugins in Drupal core that were still using the deprecated declaration had not yet been updated! Easy fix :)

Lowest number of failures yet! 🥳

Let's bring it even lower.

The last failures are caused by \Drupal\Component\Utility\ArgumentsResolver treating non-object-typehinted function arguments really weirdly. In HEAD, this automatically falls back to the BC layer (also see #5), but this patch removes that. So we have to actually fix it.

This should be green 🔥😬

🥳

 137 files changed, 186 insertions(+), 3516 deletions(-)

🙏

#57.2: oooh!!! I was looking for an issue about that, but couldn't find it! And I even reviewed that issue… 🙈

RTBC'd #3067762: Fix bug in \Drupal\rest\RequestHandler::createArgumentResolver and handle "Passing in arguments the legacy way is deprecated" deprecation, and marking this postponed on that issue.

#58 + #57.1: I'll dig into that once #3067762: Fix bug in \Drupal\rest\RequestHandler::createArgumentResolver and handle "Passing in arguments the legacy way is deprecated" deprecation lands.

Note: I'm happy to split this up into multiple patches, because this is one very big patch obviously!

Yay!

First, a straight rebase (with dozens of conflicts to resolve, which was to be expected).

This fixes #57.2 and #58. I think #58 also should have an update path test? (That's not yet in this patch.)

1. -1 to keeping the helper. That makes the test expectations much less explicit. Explicit, simple expectations are really important for tests IMHO. Sure, it's not always possible, but it is possible here.
2. You're right, #2293697: EntityResource POST routes all use the confusing default: use entity types' https://www.drupal.org/link-relations/create link template if available happened in Q2 2017 and didn't explicitly add a @trigger_error() in this hunk of \Drupal\rest\Plugin\ResourceBase::routes():
   

       // BC: the REST module originally created the POST URL for a resource by
       // reading the 'https://www.drupal.org/link-relations/create' URI path from
       // the plugin annotation. For consistency with entity type definitions, that
       // then changed to reading the 'create' URI path. For any REST Resource
       // plugins that were using the old mechanism, we continue to support that.
       if (!isset($definition['uri_paths']['create']) && isset($definition['uri_paths']['https://www.drupal.org/link-relations/create'])) {
         $create_path = $definition['uri_paths']['https://www.drupal.org/link-relations/create'];
       }
   

   BUT note that this change is fixing a bug, see #2293697-124: EntityResource POST routes all use the confusing default: use entity types' https://www.drupal.org/link-relations/create link template if available. We chose to not fix the bug in the annotation back then to avoid breaking Drupal 8 modules that were hardcoded to overwrite this particular entity type annotation key. That's why we have to change it now.

   I think it makes sense to still add a @trigger_error() in 8.8.x and 8.9.x..
   

3. ✅ — good catch!
4. ✅ — another good catch :)
5. +1, also needs follow-up. (Fun fact: the deprecation error exists, but the docs are wrong — it was first moved to serialization but before it shipped in a stable release, we moved it to hal. See #2758897: Move rest module's "link manager" services to serialization module + #2854830: Move rest/serialization module's "link manager" services to HAL module.)
6. ✅— very good call! 🙏

For points 2 and 5: attaching a 8.8/8.9 patch here to add those explicit deprecations.

Note: test coverage requested in #64/#65 still needs to be written.

The 9.0.x patch in #67 was green!

This fixes the 8.8.x deprecation patch.

1. It was explicitly in a BcTimestampNormalizerUnixTestTrait trait that got added in #2768651: Let TimestampItem (de)normalize to/from RFC3339 timestamps, not UNIX timestamps, for better DX, so … 😢You're right that it wasn't triggering a deprecation error like it should've, but it predated that practice. I'm also not entirely sure if it should have triggered a deprecation error, because it was specifically added to allow for BC-compatible testing. Tricky. Happy to expand the 8.8 patch for this if you know of a similar example!

Did you forget the interdiff in #67? That's a tough one to review as a whole again ;)

YES, SORRY! 🙈 Attached :)

Discussed #65.1 / #67.1 / #71.1 in Slack.

We settled on the compromise to indeed keep the trait to avoid any disruption for contrib/custom modules that are using this (because it wasn't properly deprecated, this predates the deprecation process), and instead deprecate this in D9, for removal in D10. Updated https://www.drupal.org/node/2859657 accordingly.

Important note: you're not required to use (new \DateTime())->setTimestamp(123456789)->setTimezone(new \DateTimeZone('UTC'))->format(\DateTime::RFC3339) — you can just write an RFC3339-formatted timestamp instead, i.e. just a string. You only need the complexity in case your timestamps are programmatic rather than hardcoded.
In core, I preferred to opt for the more complex programmatic approach because that is more copy-pasteable. I'm happy to change that if people disagree though.

Fix mistake in IS.

Added the requested test coverage (for rest_update_9001()).

And to avoid conflict with #3087644: Remove Drupal 8 updates up to and including 88** like @jibran mentioned in #49 and @Berdir in #65.6, unremoving all the update path test removals.

This means we go from

 138 files changed, 222 insertions(+), 3417 deletions(-)

to

 124 files changed, 221 insertions(+), 2589 deletions(-)

The reduced reduction will be handled in #3087644: Remove Drupal 8 updates up to and including 88**. Rather unsatisfying, but logical :)

#76: I followed a pre-existing pattern.

Missed one spot. (Discovered by manually comparing to #3087644: Remove Drupal 8 updates up to and including 88**'s patch.)

Final diffstat:

 124 files changed, 258 insertions(+), 2561 deletions(-)

(In #79 I also discovered two bugs in #3087644 — see #3087644-91: Remove Drupal 8 updates up to and including 88**.)

#3087644: Remove Drupal 8 updates up to and including 88** landed! Rerolling 🥳

1. Fixed the one coding standard violation.
2. (The failing test was removed by #3087644: Remove Drupal 8 updates up to and including 88**, so nothing left to do about that.)
3. Addressed @Berdir's remarks in #76/#83. Note that for now I went with installing the entity type definition using the API instead of updating the fixture. I still need to update the fixture. @Berdir pointed me to #3095333: Extend filled database dump with new stable modules and content for them — if that issue were done, we wouldn't have to deal with generating a complex fixture.
4. Also addressed @Berdir's remark in #84.
5. Removed core/modules/views/tests/modules/views_test_config/test_views/views.view.rest_export_with_authorization_correction.yml because #3087644 didn't do that after all.

 125 files changed, 273 insertions(+), 2792 deletions(-)

Thanks for double-checking #87 with drupal-check, @Stefdewa! 🙏🙏🙏🥳

#90 Woah, of course. Good catch. I'm glad you're looking at this :)

Also, regarding #87.3:

berdir 5 minutes ago
let me look at the patch, I can IMHO live with doing it through the API, maybe with a @todo on the other issue?

berdir 3 minutes ago
yeah, I'd definitely be OK with just adding a comment that says, this used to be done by an update function and can be removed once we have a database dump that officially installed the rest.module

Yay!

Is #2893804-70: Remove rest.module BC layers still the right patch for 8.8.x/8.9.x? If so that seems fine

Yes.

(although could also have been spun-out to a side issue and committed with no other dependencies).

I had forgotten that even existed until your reminder just now. You're right.

1. BC removal is the entire reason for the layer of indirection in the current test coverage; removing the layer of indirection is simplification directly enabled by the BC removal. That's why I felt strongly about this. I'm glad you are okay with it :)
2. I 🤔… think you're right. 🙂 Done. ✅

Although i'm not sure the upgrade path test is going to work now - we might not need to reset the schema version, but we might need to manipulate the post updates entry.

I did run \Drupal\Tests\rest\Functional\Update\RestSettingsDeletionUpdateTest locally and it still passes :)

#97: Fascinating. I didn't do anything special here. I just copy/pasted the pattern of how all of the REST module fixtures used to work until #3087644: Remove Drupal 8 updates up to and including 88** removed them. And AFAICT just about every fixture follows this pattern?

I'm not sure I understand what's "brute force" about this; AFAICT that's how it was intended to work — at least back when we started doing these update path tests. Perhaps there's a better pattern by now? If so, we should look into applying that to all core update path tests.
EDIT: Ah now I see, it's this: (meaning they'll all run). — this is true, that is what happens. That has always puzzled me about our update path tests. I haven't yet seen any update path test fixture that defines which post updates have already run.

Yay!

Unpostponed #2893795: Remove serialization.module BC layers and #3034062: Remove hal.module BC layers — their patches are currently being tested by DrupalCI. If they need rerolls, they should be easy.

#102: Yep, makes perfect sense :)