Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
See #2800873-131: Add XML GET REST test coverage, work around XML encoder quirks.2 and #2800873-152: Add XML GET REST test coverage, work around XML encoder quirks.
Proposed resolution
Add test coverage to EntityResourceTestBase::testPatch().
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2905686-4.patch | 2.74 KB | wim leers |
Comments
Comment #2
wim leersComment #3
wim leers#2800873: Add XML GET REST test coverage, work around XML encoder quirks is in, now we can continue here.
Comment #4
wim leersI think just
PATCHtest coverage is enough.Here's that test coverage.
Comment #5
wim leersComment #6
dawehnerThis looks perfect, thank you!
For a while I was thinking, could we make this file more readable overall by introducing readable helper functions like:
patchMultiValueFields. This would be of course out of scope here, but such big functions don't make it obvious without reading them from top to the bottom of all the possible cases it covers.Comment #7
wim leersI agree — now that the test coverage is approaching completion, we can and should look into simplifying it!
Comment #9
wim leersLooks like catch committed this one, yay! :)