Release signup 6.x-1.0-rc4

Added #363337

I'm done with all the known-issues I wanted to solve. If anyone's available to test the end of the DRUPAL-6--1 branch and report their findings here, that'd be much appreciated.

The other things that'd be nice to have before the release, but not critical, are:
#359408: Document all signup hooks in signup.api.php
#356391: Expose signup-related node actions
#174805: add way to signup-enable existing nodes in bulk

Yup, good point, thanks! See #51226-40: allow users to edit their own signup. This is now blocked until that's resolved.

Should probably commit #363760: Port to changed VBO API -- hook_views_bulk_operations_object_info() before I release, too -- reviews/comments welcome.

All known issues are committed again... back to CNR if anyone wants to test the end of the DRUPAL-6--1 branch before I tag and release.

(Here are the draft release notes -- just waiting for any last-minute testing before I finalize the tag and create the release node).

Bugs fixed since version 6.x-1.0-rc3

• #350548 by dww: Fixed logic bug in the support for Event module which would close signups prematurely if you edited event nodes in the future.
• #354944 by stBorchert: Fixed bug where changes to signup settings were lost during node previews (in Drupal 6.x only).
• #350872 by gargoyle and dww: Fixed bug where node type names were used unquoted as table aliases in the SQL for the admin/content/signup page. If you had a node type named after an SQL reserved word (e.g. 'match'), you'd get SQL errors. Now, node type names are properly quoted.
• #181272 by dww: Fixed bug where the labels on the custom signup form fields were not properly translatable when this data was displayed in other places (when viewing your own signup info, etc).
• #358787 by dww: Fixed bug with exposed filters in signup's embedded views.
• #356968 by dww and elonen: Fixed bug where line endings were stripped from signup-generated emails since drupal_html_to_text() was being called even though the signup email templates only support plain text.

New features since version 6.x-1.0-rc3

• #51226 by dww: Added the ability to edit existing signups.
  • Added an "edit own signups" permission.
  • The current signup information is now displayed via a form, not a table. The form is disabled at first, but if the user has permission to edit their signup, there's an "Edit" button that they can click which enables all the form elements and renames itself "Save".
  • Added an "User: Edit signup link" views field handler. A column of "Edit signup" links is now included in the default admin views.
• #361446 by dww: Restored the ability to have the signup user list embedded directly on each node, instead of forcing it into a subtab at node/N/signups/list (#349292). There are now extra options for the "How to display the list of signed-up users" advanced setting, and the list is now a separate entry in each node's content[] array so it can be ordered independently of the signup form.
• #355152 by dww: Added the ability to create "user views" that include signup data by exposing more JOIN and relationship info to views.
• #352328 by dww: Added the ability to create "signup views" by exposing {signup_log} as a valid base table for views.
• #356390 by dww: Converted the "signup_user_list" default view into a "signup view" instead of a "node view", since it's a view of signups.
• #352328 by dww: Added support for Views Bulk Operations (VBO).
  • Exposed some actions on signup objects (cancel, mark attendance, etc).
  • Added a setting to embed a view for admin/N/signups/admin.
  • Added a new default VBO view to embed when VBO is enabled.
• #361073 by dww: Improved the UI for canceling your own signup:
  • The cancel operation is now triggered by a text link, not a button.
  • The link goes to the confirm form used for the cancel URL (#325237).
  • The "Keep signup" link honors any destination set via the URL.
• #363337 by dww: Improved the UI for the advanced settings by trimming the description of views to embed if they get too long.
• #341835 by dww: Added an exposed filter for the "Signup status" to the default view of a user's current signups ("signup_current_signups").
• #360009 by dww: Added a checkbox setting to disable printing the signup information on user profile pages when Views is not enabled.

API changes since version 6.x-1.0-rc3

• #357655 by dww: Added a signup_send_broadcast() function that can be shared, and renamed signup_get_email_addresses() to signup_get_signups() to be more accurate and more easily reused.
• #51226 by dww: API changes related to editing existing signups:
  • Canceling your own signup is now handled via the "signup_edit_form" instead of a separate "signup_cancel_form".
  • Removed a bunch of deprecated theme functions since the signup is now displayed via a form, not a table: theme_signup_current_signup(), theme_signup_custom_data_table(), and theme_signup_custom_data_rows().
  • Renamed theme_signup_email_token_anonymous_username() to be theme_signup_anonymous_username() since it's now used for other things.

Other changes since version 6.x-1.0-rc3

• #349727 by dww: Removed ancient DB update functions from before D5.
• #363760 by dww: Ported to the new hook_views_bulk_operations_object_info() API (#362534), but still supporting the old hook_object_info() API for now.
• #359408 by dww: Documented all hooks invoked by Signup in signup.api.php.

Blocked on #367937: Attendance field is always visible on 'signup/edit/SID' form

#367937: Attendance field is always visible on 'signup/edit/SID' form is now fixed. The only other issues on my radar before rc4 (and probably soon thereafter, 6.x-1.0) are:

#370397: All anonymous signups cancelled when any user is deleted
#372880: %node_start_time is replaced with an empty string
#375573: %user_signup_info not included in signup_forwarding_email

Oh, and definitely this:
#373260: Allow users with 'administer signups' perms on a node to view the attendee list
and maybe this:
#367297: Restrict users from viewing other users signups

signup 6.x-1.x-dev has existed for a very long time.

Still blocked on these two:

#367297: Restrict users from viewing other users signups
#370397: All anonymous signups cancelled when any user is deleted

All the blockers are now fixed and committed. Here are the updated release notes. Any final testing of 6.x-1.x-dev or the end of DRUPAL-6--1 branch before I release would be most appreciated. Thanks!

-Derek

Bugs fixed since version 6.x-1.0-rc3

• #370397 by ezra-g: Fixed critical data-loss bug where all anonymous signups would be destroyed if any authenticated user was deleted. This bug was introduced during the port to Drupal 6 core, due to an undocumented API change between Drupal core versions 5 and 6.
• #350548 by dww: Fixed logic bug in the support for Event module which would close signups prematurely if you edited event nodes in the future.
• #354944 by stBorchert: Fixed bug where changes to signup settings were lost during node previews (in Drupal 6.x only).
• #350872 by gargoyle and dww: Fixed bug where node type names were used unquoted as table aliases in the SQL for the admin/content/signup page. If you had a node type named after an SQL reserved word (e.g. 'match'), you'd get SQL errors. Now, node type names are properly quoted.
• #181272 by dww: Fixed bug where the labels on the custom signup form fields were not properly translatable when this data was displayed in other places (when viewing your own signup info, etc).
• #358787 by dww: Fixed bug with exposed filters in signup's embedded views.
• #356968 by dww and elonen: Fixed bug where line endings were stripped from signup-generated emails since drupal_html_to_text() was being called even though the signup email templates only support plain text.
• #367937 by dww: Fixed bug where any user who can edit their own signup could record their own attendance at signup/edit/[sid].
• #389952 by dww: Fixed a bunch of bugs in the "signup node link" views field.
• #390000 by KarenS, dww: Ported signup to the Date 6.x-2.0 API for date format strings that was introduced at #318008.
• #375573 by dww: Fixed bug where the %user_signup_info token was not being used in the signup_forwarding_email message (the "Send signups to" field for notifications on new signups).
• #367297 by dww: Changed the default signup views so that only the user (and signup administrators) can view their own signups.
• #471562 by dww: Fixed broken link to the signup broadcast tab on the signup administration page at admin/content/signup (this bug was introduced in version 6.x-1.0-rc3 via #349292).
• #480278 by ezra-g: Removed a superfluous user_access() check inside signup_sign_up_user() that can prevent proper programmatic signups.

New features since version 6.x-1.0-rc3

• #51226 by dww: Added the ability to edit existing signups.
  • Added an "edit own signups" permission.
  • The current signup information is now displayed via a form, not a table. The form is disabled at first, but if the user has permission to edit their signup, there's an "Edit" button that they can click which enables all the form elements and renames itself "Save".
  • Added an "User: Edit signup link" views field handler. A column of "Edit signup" links is now included in the default admin views.
• #361446 by dww: Restored the ability to have the signup user list embedded directly on each node, instead of forcing it into a subtab at node/N/signups/list (#349292). There are now extra options for the "How to display the list of signed-up users" advanced setting, and the list is now a separate entry in each node's content[] array so it can be ordered independently of the signup form.
• #355152 by dww: Added the ability to create "user views" that include signup data by exposing more JOIN and relationship info to views.
• #352328 by dww: Added the ability to create "signup views" by exposing {signup_log} as a valid base table for views.
• #356390 by dww: Converted the "signup_user_list" default view into a "signup view" instead of a "node view", since it's a view of signups.
• #352328 by dww: Added support for Views Bulk Operations (VBO).
  • Exposed some actions on signup objects (cancel, mark attendance, etc).
  • Added a setting to embed a view for admin/N/signups/admin.
  • Added a new default VBO view to embed when VBO is enabled.
• #361073 by dww: Improved the UI for canceling your own signup:
  • The cancel operation is now triggered by a text link, not a button.
  • The link goes to the confirm form used for the cancel URL (#325237).
  • The "Keep signup" link honors any destination set via the URL.
• #363337 by dww: Improved the UI for the advanced settings by trimming the description of views to embed if they get too long.
• #341835 by dww: Added an exposed filter for the "Signup status" to the default view of a user's current signups ("signup_current_signups").
• #360009 by dww: Added a checkbox setting to disable printing the signup information on user profile pages when Views is not enabled.

API changes since version 6.x-1.0-rc3

• #357655 by dww: Added a signup_send_broadcast() function that can be shared, and renamed signup_get_email_addresses() to signup_get_signups() to be more accurate and more easily reused.
• #51226 by dww: API changes related to editing existing signups:
  • Canceling your own signup is now handled via the "signup_edit_form" instead of a separate "signup_cancel_form".
  • Removed a bunch of deprecated theme functions since the signup is now displayed via a form, not a table: theme_signup_current_signup(), theme_signup_custom_data_table(), and theme_signup_custom_data_rows().
  • Renamed theme_signup_email_token_anonymous_username() to be theme_signup_anonymous_username() since it's now used for other things.
• #424338 by rjl, ezra-g, dww: Changed the API in signup_sign_up_user() to return the new signup ID (SID) for any successful signup.

Other changes since version 6.x-1.0-rc3

• #349727 by dww: Removed ancient DB update functions from before D5.
• #363760 by dww: Ported to the new hook_views_bulk_operations_object_info() API (#362534), but still supporting the old hook_object_info() API for now.
• #359408 by dww: Documented all hooks invoked by Signup in signup.api.php.
• #373260 by dww: Changed access logic so that users that can administer signups on a given node can always view the signup attendees on that node.
• #506324 by mlsamuelson: Made messages printed to the screen after a successful signup more user-generic to work better for programmatic signups and cases where administrators sign up other users.
• #376330 by joostvdl: Added a Dutch (nl) translation.

signup 6.x-1.0-rc4