Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Mar 2016 at 17:11 UTC
Updated:
21 Feb 2017 at 11:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
drunken monkeyWe now actually use the tracker description – but only if the tracker has a config form. So that needs to change, plus the datasource description (which is, apparently, still unused).
Comment #3
drunken monkeyHere's one suggestion: Just use the descriptions as descriptions for the radio buttons. Very straight-forward, and solves all problems, as far as I can see.
Did the same for server backends, while I was at it – makes things consistent, and also displays the description if a server has no config form. (Might have worked before, too, though – not sure.)
I also removed the
ContentEntity::getDescription()override, since that didn't really make any sense for how the description is now used (and, in general, for what a description is supposed to be – it was more a config summary, really, like Views'adminSummary()).Finally, I changed the magic config key the server is passed into the backend plugin constructor to
#server– we already did that for index plugins a while back, but seem to have forgotten to do the same for backends.Probably should get some tests to make sure the descriptions are correctly displayed, but I gotta go now, so no time at the moment.
Comment #4
drunken monkeySimple enough. ("Tests only" patch is the interdiff.)
Comment #5
drunken monkeyComment #6
borisson_Testbot is really slow today, patch looks good and has coverage. Great work Thomas
Comment #9
drunken monkeyThanks for reviewing, good to hear!
Let's see whether we can get the test bot to approve, too …
Comment #11
drunken monkeyHuh, weird … Let's try with this one, shortly, to maybe get more helpful diagnostics. (Not a real suggestion.)
Comment #13
drunken monkeyComment #15
drunken monkeyWhat.
Does anyone have any explanation for this?
Trying with an additional cast, maybe that's it?
Comment #17
drunken monkeyAs said in a different issue, I just get an "A non-numeric value encountered" error when running functional tests locally at the moment. Can anyone reproduce this fail (and possibly debug)? Otherwise, I guess an issue in the Drupal CI queue is in order.
Comment #18
borisson_I ran the tests locally and I can reproduce the issue, the command i used is:
$ vendor/bin/phpunit -c core/ modules/globalignore/search_api --filter testFramework --printer="\Drupal\Tests\ListenerThe error is:
Failed asserting that 'File Provides File entities for indexing and searching. Search task Provides Search task entities fo' contains "Provides <em class="placeholder">File</em> entities for indexing and searching."., I think the placeholder is what's wrong here.I'll try to figure out how to actually fix that after I've had food.
Comment #19
drunken monkeyAh, that does make sense. Thanks a lot for testing, this really helped me out!
The attached patch should fix this, I'd say (interdiff based on #4).
Also opened #2849425: Test bot apparently strips tags from fail/error message for the test bot – this is really not a very helpful behavior.
Comment #21
drunken monkeyDamn. #2849507: Fix test fails on Drupal 8.4
Comment #22
drunken monkeyComment #23
borisson_Such a small change, well done @drunken monkey! Thanks for picking this up after I'd said I'd do it. Sorry.
Comment #25
drunken monkeyNo problem at all! You still deserve credit for reproducing the test fail and thus helping me find the problem. As you see, it just required a small change, so I'd thought I'd just make that change.
Anyways, good to see this finally passing. Committed.
Thanks again for your help!