In #2423449: Convert the overview of scheduled nodes into a view the scheduled node lists were converted to Views. As part of the work the original access check on these lists was removed and replaced by the internal access checks of Views. We should test that only users with the right permissions can access scheduled content lists. Also, users should only be able to see their own (unpublished) scheduled content unless they have the "view scheduled content" permission.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2592293-7.test_access_to_scheduled_content_view.patch | 6.32 KB | jonathan1055 |
Comments
Comment #2
mr.baileysComment #3
jonathan1055 commentedJust for the record, here is a patch which contains just the new test file from #2755665-4: Restore original access requirement for scheduled content overview.. This will produce some failures because, as we know, the access is not correct in the current code base.
Comment #5
jonathan1055 commentedI have re-worked the excellent test file created in #2755665-4: Restore original access requirement for scheduled content overview.. There were some existing faults which the tests did not trap, and an assumption which differs from how the 7.x permissions were working, which led to an incorrect 'all green' pass with the new code fix patch.
Here is just the new test, to see how the existing committed code performs. According to my local testing there should be 13 failures here.
Comment #7
jonathan1055 commentedAs expected, 102 passes and 13 fail (7 for user tab and 6 for overview tab). I have expanded the tests to check that a user without permission cannot access another users tab, but when they do have permssion they should be able to see both published and unpublished titles. Should be 104 passes and 16 fails on existing committed code.
Comment #9
jonathan1055 commentedCorrect. 10 fails in user tab, 6 in overview. When #2755665: Restore original access requirement for scheduled content overview. is committed I will re-queue the above patch
Comment #11
jonathan1055 commentedAll green passes for the committed code now. Thank you @mr.baileys for starting the tests. I decided to commit them on this issue, not on #2755665: Restore original access requirement for scheduled content overview., as this is where the task was originally raised.