Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Update to CKEditor 4.5.10. http://ckeditor.com/release/CKEditor-4.5.10
4.5.10 brings minor bugfixes
See also:
#1858210: [meta] Content editing experience follow-ups — in-place editing and WYSIWYG
#1950098: Update CKEditor library to 4.1
#2036253: Update CKEditor library to 4.2
#2039163: Update CKEditor library to 4.4
#2271051: Update CKEditor library to 4.4.4
#2345961: Update CKEditor library to 4.4.5
#2384581: Security: Update CKEditor library to 4.4.6
#2415111: Update CKEditor library to 4.4.7
#2521820: Update CKEditor library to 4.5.3
#2321583: Update CKEditor library to 4.5.5
#2663566: Update CKEditor library to 4.5.7
#2698587: Update CKEditor library to 4.5.8
#2724225: Update CKEditor library to 4.5.9
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2765751-8.patch | 2.61 MB | thpoul |
| #8 | interdiff-2765751-2-8.txt | 593 bytes | thpoul |
| #3 | patch.diff | 1.08 KB | dinarcon |
| #2 | 2765751-2.patch | 2.61 MB | thpoul |
Comments
Comment #2
thpoul commentedNeed to keep an eye on #2239419: Include CKEditor's AutoGrow plug-in which is already RTBC. If that gets committed first this would need a re-roll elseif this gets RTBC and gets committed first then #2239419: Include CKEditor's AutoGrow plug-in will need a re-roll. Will reference this comment there too.Edit: deleted the wrong comment since the other issue is in 8.2.x while this is in 8.1.x.
Comment #3
dinarcon commentedThanks @thpoul for updating this.
Shouldn't this be tested against the next development release 8.2.x? I tested the patch against drupal-8.2.x and it works. I think this can be applied to drupal-8.1.x and drupal-8.2.x cleanly.
A couple of questions. What process did you follow to build CKEditor? Before noticing the you had created a patch I did one too following @alexpott's process from #2724225: Update CKEditor library to 4.5.9. My patch was slightly different. Attached is the diff, but basically it is just the version. Yours reports version:"4.5.10" while mine reports version:"4.5.10 DEV". Is that relevant? How is it possible?
Comment #5
wim leersThanks for being so on top of this! :)
The changelog looks like it doesn't affect us in a significant way, or even at all.
But you forgot to update the version numbers in
core.libraries.yml, so NW for that.Committers, please favor #2239419: Include CKEditor's AutoGrow plug-in over this issue. This issue can go in at any time, the other issue is a feature that must be committed before 8.2.x's feature freeze.
#3: I suspect you didn't checkout the
4.5.10tag in git. Dogit checkout 4.5.10; sh build.sh -s. Then it'll work.Comment #6
thpoul commented@dinarcon have you pulled the latest changes of https://github.com/ckeditor/ckeditor-dev ? You should checkout the 4.5.10 tag.
This is a small release and could make it into the 8.1.x branch.
Also when posting post diffs please upload them as .txt files so the won't get tested. Test failures automatically change the issue's status to NW.
Comment #7
thpoul commented@WimLeers saw you comment right after I posted mine :) #5+1
Comment #8
thpoul commentedAnd here is the
core/core.libraries.ymlchange too :)Comment #9
wim leersPerfect!
And now repeating what I said to committers in #5:
Comment #10
dinarcon commentedHi @Wim Leers , @thpoul,
Yes, I had cloned https://github.com/ckeditor/ckeditor-dev and checked out the 4.5.10 tag. Not sure what I did wrong, but doing it again produces the same patch as the one provided. Glad to see this RTBC the same day the CKEditor update was released. :-)
Comment #11
alexpottThis can go in 8.1.x (its a patch release update) whereas #2239419: Include CKEditor's AutoGrow plug-in can not - also #2239419: Include CKEditor's AutoGrow plug-in is affected by a bug fixed in 4.5.10 so I really think this has to go first.
Committed 64c53de and pushed to 8.1.x and 8.2.x. Thanks!