event_join() takes a $type argument to specify the kind of JOIN you want, but always gives you an INNER JOIN.

CommentFileSizeAuthor
#4 328295_event_join_still_broken.4.HEAD_.patch731 bytesdww
#1 328295_event_join_type.1.patch746 bytesdww

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 328295_event_join_type.1.patch746 bytes
killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Fixed

thanks, applied to D5-2 and D6.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

dww’s picture

dww
we/he/they
commented
Version: 5.x-2.x-dev » 6.x-2.x-dev
Status: Closed (fixed) » Active
StatusFileSize
new 328295_event_join_still_broken.4.HEAD_.patch731 bytes

It seems you only partially applied my patch to HEAD. :( My patch did this:

-  return "INNER JOIN {event} e ON $prefix.nid = e.nid INNER JOIN {event_timezones} tz ON e.timezone = tz.timezone";
+  return "$type JOIN {event} e ON $prefix.nid = e.nid $type JOIN {event_timezones} tz ON e.timezone = tz.timezone";

However, event_join() in HEAD still looks like this this:

return "$type JOIN {event} e ON $prefix.nid = e.nid INNER JOIN {event_timezones} tz ON e.timezone = tz.timezone";

Please apply attached patch to fix this in HEAD. Thanks.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Active » Fixed

ok, fixed for good. D6 and D5.2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.