Implement ContainerAwareEventDispatcher::getListenerPriority()

Patch attached implementing the missing method.
The two lines

    $event->setDispatcher($this);
    $event->setName($event_name);

have been removed since those calls are deprecated since Symfony 2.4 (and will be removed in Symfony 3.x)

Added missing patch.

Confirm that it also break CLI usage with drush-8.1.0. I am now temporary apply this patch for https://www.drupal.org/project/drustack

Confirmed that this fixes the problem that I had with webprofiler enabled.

However, not sure about the removal of the deprecated calls. That's unrelated and might be causing those test fails. We can deal with that when updating to 3.0, if we actually do that.

Patch updated against latest 8.1.x branch, the deprecated calls have been restored as @berdir suggested.
Let's see if TestBot is happy again :)

Sure, why not.

It would be nice if we could expand the test coverage, I guess there is some existing test code in symfony we could just copy?

Fixed link.

Test coverage is an excellent idea as it turns out that the implementation is broken.

Fixed that plus:
1) Enabled testGetListenerPriority() from Symfony.
2) Added testGetListenerPriorityWithServices() because we do this lazy service instantiation thing in our event dispatcher, which needs to work in every method.

Making Symfony 3 update the parent issue of this.

Looks good to me. Thanks @klausi.

1. +++ b/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php
   @@ -159,6 +159,32 @@ public function getListeners($event_name = NULL) {
   +      if (FALSE !== ($key = array_search(['callable' => $listener], $listeners, TRUE))) {
   

   No yoda conditions please.

2. +++ b/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php
   @@ -159,6 +159,32 @@ public function getListeners($event_name = NULL) {
   +
   

   Extra blank line.

3. +++ b/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php
   @@ -159,6 +159,32 @@ public function getListeners($event_name = NULL) {
   +          $definition['callable'] = [$this->container->get($definition['service'][0]), $definition['service'][1]];
   

   Needs a comment as to why we're setting the callable as well as returning the priority. The interface docs mention nothing about this for example.

Yoda conditions: this is code copied from Symfony, so we should add a comment: "// Code copied from Symfony, that's why we use yoda conditions here."

The blank line between functions should there, it is just the diff that looks weird.

Setting the callable: this is the lazy loading our Drupal specific implementation does. For the comparison we need the callable, and for subsequent calls we cache it on the object, as we do in the other methods of this class. Comment should be "// Cache the callable here to have it read on subsequent invocations."

Added those comments.

Ok. Let's see what @catch thinks about it now.

Random fail.

The usual random migrate module fail, back to RTBC.

Not convinced about copying the yoda condition from Symfony, feels like a slippery slope. But easy to reverse in a minor coding standards issue another time and the parent issue is very important.

+++ b/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php
@@ -159,6 +159,36 @@ public function getListeners($event_name = NULL) {
+    }
+    // Resolve service definitions if the listener has not been found so far.
+    foreach ($this->listeners[$eventName] as $priority => &$definitions) {
+      foreach ($definitions as $key => &$definition) {
+
+        if (!isset($definition['callable'])) {

That's not between a function, but fixed on commit.