We need to add schema entries for block_page and simple_page plugin types.

(More details coming soon...)

Comments

yanniboi created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Why do we need schema for them if we don't support them?

yanniboi’s picture

yanniboi commented

Good catch berdir :P #2550879: Use CTools Wizard API to add/edit Pages (and move plugin UI using PluginWizardInterface) has some failing tests because of missing schema, but in light of your post, I think we should take a closer look at those tests rather than just creating schema for something we dont support.

eclipsegc’s picture

eclipsegc commented

This is kind of what I was talking about back on the issue. If the introduction of new features highlights missing schema, or whatever, unless it's reproduce-able in the current code base, I don't see why we'd break it out.

juampynr’s picture

juampynr commented

I have removed that from the patch at https://www.drupal.org/node/2550879#comment-11000001. Therefore, I think that we could close this one.

andrewbelcher’s picture

andrewbelcher commented
Status: Active » Closed (works as designed)

As per @juampynr's comment, looks like this was a spurious fail in the first place and is working correctly.

andrewbelcher’s picture

andrewbelcher commented
Issue tags: -pm-ui-blocker
Parent issue: #2550879: Use CTools Wizard API to add/edit Pages (and move plugin UI using PluginWizardInterface) »

Removing tag/parent to remove noise.