hello there,
First of all thanks for this great module. it is very impressive that takes the rules into next level. Recently i have been using this module with commerce_coupon module for coupon inline conditions. And then i added two inline conditions in commerce_coupon with OR as operator so that if one of them is true then coupon will be validated. But unfortunately i was just stuck. It is not working. It is treating OR operator as a AND operator as if both of them are true then coupon is validated but that was not my case. I have done a lot to make it happen correctly. So please help me how to use OR operator. I also made two custom inline conditions as documented by your module api. Both inline conditions works fine as it was purposely made but again if i add both conditions with OR operator it just treat OR as if it's a AND operator.
Pleas look into this matter as that module is being used by a lot of other contributed modules.
thanks
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | commerce_abandoned_cart_notify.zip | 3.32 KB | rahu231086 |
Comments
Comment #1
jkuma commentedHello rahu231086,
First of all, thank you for your kind message. May you send me the export of the rule generated? We need to figure out how the module rules react when using the OR operator. I've got plenty of time next week, I would be very keen to help you.
Comment #2
rahu231086 commented@jkuma it's not possible. As commerce coupon module does not generate the rule. Commerce discount module do generate the rule based on inline conditions but commerce coupon module does not generate any rule. It directly calls the inline condition from api to check coupon access.
Comment #3
jkuma commentedok @rahu231086, I'll try to reproduce the issue with commerce_coupon. From your first post, you said that you have added two inline condition, can you tell me their name ? Also, can you please forward me as much as possible all details about the creation of your coupon discount.
Comment #4
rahu231086 commentedok @jkuma
Here i am attaching my hook module.rules.inc and module.inline_conditions.inc in a zip format
Please see this
thanks
Comment #5
jkuma commentedComment #6
jkuma commentedDear Commerce Coupon maintainer,
rahu231086 has raised an issue about problems he/she is facing with the OR operator of an inline condition. From my perspective, it seams commerce_coupon has a custom implementation of inline_conditions and the hook_inline_conditions_build() is not implemented by this module. That means, the processing of logical operators are no longer handled by inline_conditions module but by commerce_coupon own callbacks.
This approach appears wrong because commerce_coupon does not rely on inline_conditions internal callbacks to manage logical operators processing.
May you help rahu231086 ?
Comment #7
torgospizzaI think we're seeing a potential manifestation of this, and I would like to help. However, I don't see any documentation for hook_inline_conditions_build(). Am I missing it? My apologies if that's the case.