CommentFileSizeAuthor
#161 test-classy-with-stable-full-1.patch194.36 KBstar-szr
#156 kittens-kittens.patch3.82 KBlauriii
#153 classy-stable-chickens-eggs.patch1.27 KBstar-szr
#151 classy-stable.patch388 bytesstar-szr
#148 allow_base_themes_to-2574975-17.patch2.8 KBstar-szr
#145 hidden-themes.patch10.6 KBstar-szr
#142 add_a_stable_base_theme-2575421-92-test.patch162.6 KBstar-szr
#139 2575421-71-add-stable-theme-libraries2.patch181.79 KBstar-szr
#136 2575421-71-add-stable-theme-libraries.patch195.97 KBstar-szr
#133 add_a_stable_base_theme-2575421-33-test.patch10.52 KBstar-szr
#128 add_a_stable_base_theme-2575421-19-test2.patch9.71 KBstar-szr
#128 add_a_stable_base_theme-2575421-19-test1.patch11.01 KBstar-szr
#124 safe-theme-1.patch1.3 KBstar-szr
#119 add_twig_filter_for-2571561-8.patch5.74 KBstar-szr
#117 twig_2.x-make_necessary_changes-2568181-23-testmillion.patch381.44 KBstar-szr
#115 test-twig-html-strategy.patch737 bytesstar-szr
#113 remove_race_condition-2571817-2-test.patch17.18 KBstar-szr
#111 twig_2.x-make_necessary_changes-2568181-23.patch375.27 KBstar-szr
#109 make_necessary_changes-2568181-23.patch9.94 KBstar-szr
#108 twig_2.x-make_necessary_changes-2568181-23-test.patch361.59 KBstar-szr
#107 upgrade_to_twig_1_22-2568171-73-test.patch59.9 KBstar-szr
#98 upgrade_to_twig_1_dev-uncomment.patch60.46 KBstar-szr
#97 upgrade_to_twig_1_dev.patch60.53 KBstar-szr
#1 7269-194-minimum-test.patch142.63 KBstar-szr
#1 interdiff.txt1.99 KBstar-szr
#4 7269-194-wip1.patch167.53 KBstar-szr
#4 interdiff.txt29.04 KBstar-szr
#6 7269-194-wip2.patch166.54 KBstar-szr
#6 interdiff.txt1018 bytesstar-szr
#8 ignore_patch_testing-2426563-8.patch94.79 KBjoelpittet
#10 interdiff.txt7.05 KBjoelpittet
#10 ignore_patch_testing-2426563-10.patch171.64 KBjoelpittet
#11 2429447-test.patch46.98 KBdawehner
#13 2429447-13.patch78.6 KBdawehner
#16 2426563-16.patch103.99 KBdawehner
#18 2348747-64.patch575 bytesstar-szr
#20 2348747-64-with-twig.patch9.57 KBstar-szr
#21 twig-views-view-fields-2348747-46-interdiff.txt1.45 KBmanuel garcia
#24 1944572-41.patch2.68 KBstar-szr
#26 1944572-41b.patch2.73 KBstar-szr
#26 interdiff.txt587 bytesstar-szr
#27 1944572-43.patch14.51 KBstar-szr
#28 test-toolbar-selector.patch522 bytesstar-szr
#29 2426563-29.patch5.42 KBdawehner
#31 field-parent-initial.patch1.25 KBstar-szr
#31 form-file-initial.patch2.49 KBstar-szr
#31 form-item-initial.patch20.3 KBstar-szr
#31 form-item--initial.patch14.8 KBstar-szr
#31 form-type--initial.patch5.87 KBstar-szr
#31 form-required-initial.patch13.2 KBstar-szr
#31 form-submit-initial.patch2.98 KBstar-szr
#31 text-forms-initial.patch4.49 KBstar-szr
#31 form-wrapper-initial.patch5.93 KBstar-szr
#32 form-submit-full.patch3.72 KBstar-szr
#32 form-item-full.patch21.95 KBstar-szr
#32 form-file-full.patch8.32 KBstar-szr
#32 form-item--full.patch17.89 KBstar-szr
#32 field-parent-full.patch1.83 KBstar-szr
#37 form-type--full.patch5.91 KBstar-szr
#37 form-required-initial2.patch11.41 KBstar-szr
#38 2273925-test-contextual.patch16.09 KBstar-szr
#40 upgrade_path_plan_to-2555243-24.patch354.25 KBstar-szr
#42 interdiff.txt1.03 KBstar-szr
#43 upgrade_path_plan_to-2555243-25.patch354.58 KBstar-szr
#43 interdiff.txt592 bytesstar-szr
#47 upgrade_path_plan_to-2555243-26.patch355.36 KBstar-szr
#47 interdiff.txt798 bytesstar-szr
#48 upgrade_path_plan_to-2555243-26-2.patch355.35 KBstar-szr
#48 interdiff.txt786 bytesstar-szr
#54 upgrade_path_plan_to-2555243-28.patch355.46 KBstar-szr
#54 interdiff.txt900 bytesstar-szr
#55 upgrade_path_plan_to-2555243-28-2.patch356.33 KBstar-szr
#55 interdiff.txt1.28 KBstar-szr
#60 upgrade_path_plan_to-2555243-28-3.patch356.82 KBstar-szr
#60 interdiff.txt921 bytesstar-szr
#61 upgrade_path_plan_to-2555243-28-4.patch358.61 KBstar-szr
#61 interdiff.txt2.68 KBstar-szr
#66 upgrade_path_plan_to-2555243-28-5.patch359.64 KBstar-szr
#66 interdiff.txt2.45 KBstar-szr
#69 upgrade_path_plan_to-2555243-28-5.patch359.64 KBstar-szr
#70 upgrade_twig_test_1.x-1.patch42.46 KBstar-szr
#72 upgrade_twig_test_1.x-2.patch42.46 KBstar-szr
#73 interdiff.txt3.77 KBstar-szr
#76 upgrade_twig_test_clean_1.x.patch30.65 KBstar-szr
#81 upgrade_twig_test_1.x-3.patch42.67 KBstar-szr
#84 upgrade_twig_test_1.x-4.patch42.98 KBstar-szr
#87 upgrade_twig_test_1.x-5.patch43 KBstar-szr
#89 upgrade_twig_test_1.x-cache2.patch57.15 KBstar-szr
#90 upgrade_twig_test_1.x-cache3.patch57.19 KBstar-szr
#93 upgrade_twig_test_1.x-cache4.patch68 KBstar-szr
#94 upgrade_twig_test_1.x-cache5.patch67.69 KBstar-szr
#95 upgrade_twig_test_1.x-cache6.patch67.3 KBstar-szr
#96 upgrade_to_twig_1_22-2568171-68.patch60.05 KBstar-szr
#96 upgrade_to_twig_1_22-2568171-72.patch60.11 KBstar-szr

Comments

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new 7269-194-minimum-test.patch142.63 KB
new interdiff.txt1.99 KB

See what breaks for now.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: 7269-194-minimum-test.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 7269-194-wip1.patch167.53 KB
new interdiff.txt29.04 KB

Status: Needs review » Needs work

The last submitted patch, 4: 7269-194-wip1.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 7269-194-wip2.patch166.54 KB
new interdiff.txt1018 bytes
ParisLiakos’s picture

ParisLiakos commented

great, looks good and not that bigger..lets take it to tha main issue?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new ignore_patch_testing-2426563-8.patch94.79 KB

Status: Needs review » Needs work

The last submitted patch, 8: ignore_patch_testing-2426563-8.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt7.05 KB
new ignore_patch_testing-2426563-10.patch171.64 KB
dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 2429447-test.patch46.98 KB

.

Status: Needs review » Needs work

The last submitted patch, 11: 2429447-test.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 2429447-13.patch78.6 KB

.j

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review

.

Status: Needs review » Needs work

The last submitted patch, 13: 2429447-13.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2426563-16.patch103.99 KB

Next one

Status: Needs review » Needs work

The last submitted patch, 16: 2426563-16.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new 2348747-64.patch575 bytes
star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new 2348747-64-with-twig.patch9.57 KB
manuel garcia’s picture

manuel garcia commented
StatusFileSize
new twig-views-view-fields-2348747-46-interdiff.txt1.45 KB

I've been testing this patch, and all seems in order. Malicious code is still escaped as expected, for example:
Tried entering <script>alert('hacked');</script> as a class for a field, the result is class="scriptalerthacked-script".
I also tried a variety of other strings, everything is secured by twig, as expected.

I do have one question on this patch though, ran an interdiff with the latest patch on the main issue (#46), which you can find attached.

My question is on this part:

+use Drupal\Core\Field\FieldDefinitionInterface;

And:

+  /**
+   * {@inheritdoc}
+   */
+  public static function generateSampleValue(FieldDefinitionInterface $field_definition) {
+    $values['status'] = TRUE;
+    return $values;
+  }

Is this on preparation for a test or?

star-szr’s picture

star-szr
he/him
Primary language English
commented

@Manuel Garcia where are you seeing those changes? Did you forget to rebase maybe? I'm not seeing those in the patch in #18 or #20.

manuel garcia’s picture

manuel garcia commented

Oh my god Cottser sorry... thats coming because I have another patch applied to fix the problem with devel_generate.. #2422101: CommentItem should override the generateSampleValue method and provide sample values... please ignore.

I think we are ready to put this into the main issue, will do that now, thanks!

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new 1944572-41.patch2.68 KB

Status: Needs review » Needs work

The last submitted patch, 24: 1944572-41.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 1944572-41b.patch2.73 KB
new interdiff.txt587 bytes
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new 1944572-43.patch14.51 KB
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new test-toolbar-selector.patch522 bytes
dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 2426563-29.patch5.42 KB

Just research.

Status: Needs review » Needs work

The last submitted patch, 29: 2426563-29.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new field-parent-initial.patch1.25 KB
new form-file-initial.patch2.49 KB
new form-item-initial.patch20.3 KB
new form-item--initial.patch14.8 KB
new form-type--initial.patch5.87 KB
new form-required-initial.patch13.2 KB
new form-submit-initial.patch2.98 KB
new text-forms-initial.patch4.49 KB
new form-wrapper-initial.patch5.93 KB

Initial versions first.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new form-submit-full.patch3.72 KB
new form-item-full.patch21.95 KB
new form-file-full.patch8.32 KB
new form-item--full.patch17.89 KB
new field-parent-full.patch1.83 KB

And updated ones where applicable.

The last submitted patch, 31: form-type--initial.patch, failed testing.

The last submitted patch, 31: form-required-initial.patch, failed testing.

The last submitted patch, 31: form-item--initial.patch, failed testing.

The last submitted patch, 31: form-item-initial.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new form-type--full.patch5.91 KB
new form-required-initial2.patch11.41 KB
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new 2273925-test-contextual.patch16.09 KB

Status: Needs review » Needs work

The last submitted patch, 38: 2273925-test-contextual.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_path_plan_to-2555243-24.patch354.25 KB

Status: Needs review » Needs work

The last submitted patch, 40: upgrade_path_plan_to-2555243-24.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new interdiff.txt1.03 KB

Interdiff for the last one, note that this hacks vendor, see https://github.com/twigphp/Twig/issues/1811

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_path_plan_to-2555243-25.patch354.58 KB
new interdiff.txt592 bytes

Should be greener :)

Status: Needs review » Needs work

The last submitted patch, 43: upgrade_path_plan_to-2555243-25.patch, failed testing.

The last submitted patch, 40: upgrade_path_plan_to-2555243-24.patch, failed testing.

The last submitted patch, 43: upgrade_path_plan_to-2555243-25.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_path_plan_to-2555243-26.patch355.36 KB
new interdiff.txt798 bytes

Should fix one fail or so. But I think adding Twig extensions is broken still.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_path_plan_to-2555243-26-2.patch355.35 KB
new interdiff.txt786 bytes

Status: Needs review » Needs work

The last submitted patch, 48: upgrade_path_plan_to-2555243-26-2.patch, failed testing.

The last submitted patch, 47: upgrade_path_plan_to-2555243-26.patch, failed testing.

The last submitted patch, 47: upgrade_path_plan_to-2555243-26.patch, failed testing.

The last submitted patch, 48: upgrade_path_plan_to-2555243-26-2.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented

That's why I shouldn't patch past midnight in most cases.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_path_plan_to-2555243-28.patch355.46 KB
new interdiff.txt900 bytes

Won't be green but should have better syntax ;)

Interdiff is from #47…

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_path_plan_to-2555243-28-2.patch356.33 KB
new interdiff.txt1.28 KB

Turns out Drupal\system\Tests\Theme\TwigExtensionTest is not passing for me locally even on HEAD.

So just adding some other stuff here to play with, test extension shouldn't be setting a bad example extending core's extension.

The last submitted patch, 54: upgrade_path_plan_to-2555243-28.patch, failed testing.

The last submitted patch, 54: upgrade_path_plan_to-2555243-28.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 55: upgrade_path_plan_to-2555243-28-2.patch, failed testing.

The last submitted patch, 55: upgrade_path_plan_to-2555243-28-2.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_path_plan_to-2555243-28-3.patch356.82 KB
new interdiff.txt921 bytes
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_path_plan_to-2555243-28-4.patch358.61 KB
new interdiff.txt2.68 KB
star-szr’s picture

star-szr
he/him
Primary language English
commented

Yeah it doesn't help for running this test locally when you have a twig_extension_test.twig.test_extension service in your contrib modules folder from playing around months ago :(

The last submitted patch, 60: upgrade_path_plan_to-2555243-28-3.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 61: upgrade_path_plan_to-2555243-28-4.patch, failed testing.

The last submitted patch, 61: upgrade_path_plan_to-2555243-28-4.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_path_plan_to-2555243-28-5.patch359.64 KB
new interdiff.txt2.45 KB

Getting closer…

In theory all that's left is resolving Drupal\Tests\Core\Template\TwigExtensionTest that doesn't seem to like the 't' and 'trans' filters we have defined because callable is now hinted and I guess it's not able to resolve 't' from bootstrap.inc because unit tests?

Status: Needs review » Needs work

The last submitted patch, 66: upgrade_path_plan_to-2555243-28-5.patch, failed testing.

The last submitted patch, 66: upgrade_path_plan_to-2555243-28-5.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_path_plan_to-2555243-28-5.patch359.64 KB

Doesn't have the new cache class yet but it's all I have time for at the moment. This is 1.x.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_twig_test_1.x-1.patch42.46 KB

Oops wrong file.

The last submitted patch, 69: upgrade_path_plan_to-2555243-28-5.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_twig_test_1.x-2.patch42.46 KB
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new interdiff.txt3.77 KB

It's good to learn things.

The last submitted patch, 70: upgrade_twig_test_1.x-1.patch, failed testing.

The last submitted patch, 69: upgrade_path_plan_to-2555243-28-5.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_twig_test_clean_1.x.patch30.65 KB

No other changes just the upgrade to see what happens.

The last submitted patch, 72: upgrade_twig_test_1.x-2.patch, failed testing.

The last submitted patch, 70: upgrade_twig_test_1.x-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 76: upgrade_twig_test_clean_1.x.patch, failed testing.

The last submitted patch, 72: upgrade_twig_test_1.x-2.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_twig_test_1.x-3.patch42.67 KB

Faking the cache for now.

The last submitted patch, 76: upgrade_twig_test_clean_1.x.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 81: upgrade_twig_test_1.x-3.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_twig_test_1.x-4.patch42.98 KB

Hmm forgot to include the new class.

The last submitted patch, 81: upgrade_twig_test_1.x-3.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 84: upgrade_twig_test_1.x-4.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_twig_test_1.x-5.patch43 KB

Status: Needs review » Needs work

The last submitted patch, 87: upgrade_twig_test_1.x-5.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_twig_test_1.x-cache2.patch57.15 KB
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_twig_test_1.x-cache3.patch57.19 KB

The last submitted patch, 89: upgrade_twig_test_1.x-cache2.patch, failed testing.

The last submitted patch, 89: upgrade_twig_test_1.x-cache2.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_twig_test_1.x-cache4.patch68 KB
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_twig_test_1.x-cache5.patch67.69 KB

This just removes an unneeded (old) class TwigCache that I added earlier as a temporary measure.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_twig_test_1.x-cache6.patch67.3 KB

Removes changes from #2567139: Twig autoescape default strategy deprecation error triggered on every page load.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_to_twig_1_22-2568171-72.patch60.11 KB
new upgrade_to_twig_1_22-2568171-68.patch60.05 KB
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_to_twig_1_dev.patch60.53 KB
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new upgrade_to_twig_1_dev-uncomment.patch60.46 KB

The last submitted patch, 96: upgrade_to_twig_1_22-2568171-72.patch, failed testing.

The last submitted patch, 96: upgrade_to_twig_1_22-2568171-68.patch, failed testing.

The last submitted patch, 97: upgrade_to_twig_1_dev.patch, failed testing.

The last submitted patch, 96: upgrade_to_twig_1_22-2568171-72.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 98: upgrade_to_twig_1_dev-uncomment.patch, failed testing.

The last submitted patch, 96: upgrade_to_twig_1_22-2568171-68.patch, failed testing.

The last submitted patch, 97: upgrade_to_twig_1_dev.patch, failed testing.

The last submitted patch, 98: upgrade_to_twig_1_dev-uncomment.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_to_twig_1_22-2568171-73-test.patch59.9 KB
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new twig_2.x-make_necessary_changes-2568181-23-test.patch361.59 KB
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new make_necessary_changes-2568181-23.patch9.94 KB

The last submitted patch, 108: twig_2.x-make_necessary_changes-2568181-23-test.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new twig_2.x-make_necessary_changes-2568181-23.patch375.27 KB

Status: Needs review » Needs work

The last submitted patch, 111: twig_2.x-make_necessary_changes-2568181-23.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new remove_race_condition-2571817-2-test.patch17.18 KB

The last submitted patch, 111: twig_2.x-make_necessary_changes-2568181-23.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new test-twig-html-strategy.patch737 bytes

Status: Needs review » Needs work

The last submitted patch, 115: test-twig-html-strategy.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new twig_2.x-make_necessary_changes-2568181-23-testmillion.patch381.44 KB

Status: Needs review » Needs work

The last submitted patch, 117: twig_2.x-make_necessary_changes-2568181-23-testmillion.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new add_twig_filter_for-2571561-8.patch5.74 KB

Status: Needs review » Needs work

The last submitted patch, 119: add_twig_filter_for-2571561-8.patch, failed testing.

The last submitted patch, 115: test-twig-html-strategy.patch, failed testing.

The last submitted patch, 117: twig_2.x-make_necessary_changes-2568181-23-testmillion.patch, failed testing.

The last submitted patch, 119: add_twig_filter_for-2571561-8.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new safe-theme-1.patch1.3 KB

Status: Needs review » Needs work

The last submitted patch, 124: safe-theme-1.patch, failed testing.

The last submitted patch, 124: safe-theme-1.patch, failed testing.

adamjuran’s picture

adamjuran commented
Status: Needs work » Needs review
star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new add_a_stable_base_theme-2575421-19-test1.patch11.01 KB
new add_a_stable_base_theme-2575421-19-test2.patch9.71 KB

Status: Needs review » Needs work

The last submitted patch, 128: add_a_stable_base_theme-2575421-19-test2.patch, failed testing.

The last submitted patch, 128: add_a_stable_base_theme-2575421-19-test1.patch, failed testing.

The last submitted patch, 128: add_a_stable_base_theme-2575421-19-test1.patch, failed testing.

The last submitted patch, 128: add_a_stable_base_theme-2575421-19-test2.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new add_a_stable_base_theme-2575421-33-test.patch10.52 KB

Status: Needs review » Needs work

The last submitted patch, 133: add_a_stable_base_theme-2575421-33-test.patch, failed testing.

The last submitted patch, 133: add_a_stable_base_theme-2575421-33-test.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2575421-71-add-stable-theme-libraries.patch195.97 KB

Status: Needs review » Needs work

The last submitted patch, 136: 2575421-71-add-stable-theme-libraries.patch, failed testing.

The last submitted patch, 136: 2575421-71-add-stable-theme-libraries.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2575421-71-add-stable-theme-libraries2.patch181.79 KB

Status: Needs review » Needs work

The last submitted patch, 139: 2575421-71-add-stable-theme-libraries2.patch, failed testing.

The last submitted patch, 139: 2575421-71-add-stable-theme-libraries2.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new add_a_stable_base_theme-2575421-92-test.patch162.6 KB

Status: Needs review » Needs work

The last submitted patch, 142: add_a_stable_base_theme-2575421-92-test.patch, failed testing.

The last submitted patch, 142: add_a_stable_base_theme-2575421-92-test.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new hidden-themes.patch10.6 KB

Status: Needs review » Needs work

The last submitted patch, 145: hidden-themes.patch, failed testing.

The last submitted patch, 145: hidden-themes.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new allow_base_themes_to-2574975-17.patch2.8 KB

Status: Needs review » Needs work

The last submitted patch, 148: allow_base_themes_to-2574975-17.patch, failed testing.

The last submitted patch, 148: allow_base_themes_to-2574975-17.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new classy-stable.patch388 bytes

Status: Needs review » Needs work

The last submitted patch, 151: classy-stable.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new classy-stable-chickens-eggs.patch1.27 KB

Status: Needs review » Needs work

The last submitted patch, 153: classy-stable-chickens-eggs.patch, failed testing.

The last submitted patch, 153: classy-stable-chickens-eggs.patch, failed testing.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs work » Needs review
StatusFileSize
new kittens-kittens.patch3.82 KB

At least its a start

The last submitted patch, 151: classy-stable.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 156: kittens-kittens.patch, failed testing.

The last submitted patch, 153: classy-stable-chickens-eggs.patch, failed testing.

The last submitted patch, 156: kittens-kittens.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new test-classy-with-stable-full-1.patch194.36 KB

Status: Needs review » Needs work

The last submitted patch, 161: test-classy-with-stable-full-1.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Closed (won't fix)

Dead