Views uses hyphens in many tokens, but that is not valid Twig syntax.

Duplicate of #2342287: Allow Twig in Views token replacement?

(I haven't look at this issue closely so not changing the status...)

@Wuk
So we talk about not just {{field_image}} but rather {{field_image-width}}, right? Just trying to understand exactly what is going on.
The best thing you can do IMHO in views issues is to provide a configuration file of the view, so other people can see, what exactly you have configured.

Thanks a ton.

Interesting, it works for me.

I'm able to reproduce this issue using a rewrite of To summarize, {{ body-summary }} for the body field. It results in "To summarize, 0" which may not have been output in @Wuk's view as it was seen as empty.

@dawehner: There is some strangeness going on here. When I import your view I get:

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '= '1') ))) subquery' at line 1: SELECT COUNT(*) AS expression FROM (SELECT 1 AS expression FROM {node} node WHERE (( (.status = :db_condition_placeholder_0) ))) subquery; Array ( [:db_condition_placeholder_0] => 1 )

Possibly related to #2487219: target_id is 0 in Entity Ref field when using formatters other than Entity ID?

*groan*

I know what it is... It's the hyphens in the token names -- like PHP, those are interpreted as minus by Twig resulting in bogus token names. That may be the same root issue as the issue linked above, but I haven't look at it closer.

I'll work on a patch that replaces hyphens with underscores in Views' tokens.

This will fix the issue for at least some fields. I haven't tested it thoroughly nor gone through the rest of the Views code to see where else we may be using '-' in token names. Would like to see what the testbot thinks first...

Also cleaned up a few other things while I was changing the code:

• Removed the alias to CoreXss -- unneeded
• Rewrote things a bit to remove a double-ternary statement. Icky...

Technically not in scope, I realize... But the old way of casting an object to an array has issues itself -- the array gets everything in the object including private members, which seems pretty anti-OO.

Ugh... Left a debug call in the patch -- hate it when that happens! :)

Closing #2487219: target_id is 0 in Entity Ref field when using formatters other than Entity ID as a dup of this and re-titling to better express the root cause.

Marking as "needs tests" as this is fallout from #2342287: Allow Twig in Views token replacement (and was clearly not caught by tests...)

Added issue summary and beta eval.

+++ b/core/modules/views/src/Plugin/views/field/Field.php
@@ -903,7 +903,7 @@ function render_item($count, $item) {
-      $tokens['{{ ' . $this->options['id'] . '-' . $id . ' }}'] = $this->t('Raw @column', array('@column' => $id));
+      $tokens['{{ ' . $this->options['id'] . '_' . $id . ' }}'] = $this->t('Raw @column', array('@column' => $id));

Mh I think I would use double underscore in order to remove confusion with field names including an underscore.

And yeah indeed some form of test coverage would be neat.

#15:

I think I would use double underscore in order to remove confusion with field names including an underscore.

Good call.

And yeah indeed some form of test coverage would be neat.

Agreed. But I'm having trouble figuring out where we test field plugins for entity reference fields, for example. Any pointers?

Found another use of the single-hyphen in the docblock for core/modules/views/src/Plugin/views/field/FieldPluginBase.php::addSelfTokens

Updated issue summary: double-underscores instead of single.

Rerolled.

This is looking good, thanks for staying on top of this @mikeker. I like removing the object-to-array cast. Just moving back to needs work for tests.

I came across the same problem when looking into #2453193: {{ field_youtube-input }} and {{ field_youtube-video_id }} in Views are 0 for the YouTube Field module. As this issue mentions, I was previously getting "0" when using tokens with hyphens. After applying the patch from #20 and replacing the hyphens with double underscores, I'm getting correct rewriting results for both YouTube and core field values. Thanks, mikeker et al!

Reroll. Note this should be popped back to NW after the testbot runs -- it still needs automated tests.

Added novice tasks sections to the issue summary.

@alex_drupal_dev: This patch needs automated tests. See the issue summary for details.

Possible duplicate but has tests: #2546210: Views subtokens are broken since the introduction of inline templates for replacements

Also #2546210: Views subtokens are broken since the introduction of inline templates for replacements actually modifies the tokens too :) Let's merge efforts! I don't think the issue where the merge happens matters. Here or there. Also definitely not novice.

I've merged the tests and some of the code from #2546210: Views subtokens are broken since the introduction of inline templates for replacements -- see 2371633-merge-2546210.interdiff.txt. Thanks for pointing me to that issue, @Cottser!

That issue also included the taxonomy and role handler token changes from the other issue, but updated them to show as Twig variables instead of [tokens] -- see the part2 interdiff. (@Gábor Hojtsy, #25 did change the tokens, just not all of them... :)

Agreed, I don't care which issue things more forward in -- I made the changes here since I already had this branch on my local.

Forgot to mention that the merge patch also includes the feedback from #2546210-31: Views subtokens are broken since the introduction of inline templates for replacements.

Closing as dupe of #2546210: Views subtokens are broken since the introduction of inline templates for replacements given that that one has tests. @mikeker: can you post the merged patch there to ensure you get the credit too? Thanks a lot!