Problem/Motivation

We needed to add a header to the banner from the youtube_cookies.

Proposed resolution

Patch created with a field on the module config page to print a header (or not print it if the field is empty)

CommentFileSizeAuthor
#4 3579047-youtube_cookies_header.patch6.92 KBfernandohv
#2 3579047-youtube_cookies_header.patch6.8 KBfernandohv

Issue fork youtube_cookies-3579047

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    fernandohv created an issue. See original summary.

    fernandohv’s picture

    fernandohv commented
    StatusFileSize
    new 3579047-youtube_cookies_header.patch6.8 KB
    tunic’s picture

    tunic
    he/him
    Primary language Spanish
    Location Madrid
    commented
    Status: Active » Needs work

    Patch looks good to me. Just a few comments. Can you add a description to the pop_header field in the buildForm method? Something like "This will displayed above the popup message. If empty, no title will be displayed."

    Additionally, can you create an issue fork instead of a patch?

    Thanks for the contribution!

    fernandohv’s picture

    fernandohv commented
    StatusFileSize
    new 3579047-youtube_cookies_header.patch6.92 KB

    Added changes to the patch, will try to create an issue fork latter (the option to Create new branch is not working properly).

    Thanks.