In the majority of cases setting the default implicit ARIA role for an element, like the examples below, is unnecessary and not recommended because these properties are already set by the browser. Consider removing (not setting) the default implicit ARIA roles

  • role="main" for "main" elements
  • role="banner" for "header" elements
  • role="navigation" for "nav" elements
  • role="article" for "article" elements
  • role="contentinfo" for "footer" elements

This patch will bring all of these twigs up-to-date with current implicit ARIA roles, and clearing out these w3c warnings would reduce noise coming from all types of validators.

CommentFileSizeAuthor
#11 wxt_bootstrap-w3c_warnings_unnecessary_roles-3154001-11.patch17.22 KBgdaw
#2 wxt_bootstrap-w3c_warnings_unnecessary_roles-3154001-2.patch24.38 KBgdaw

Comments

gdaw created an issue. See original summary.

gdaw’s picture

gdaw commented
StatusFileSize
new wxt_bootstrap-w3c_warnings_unnecessary_roles-3154001-2.patch24.38 KB
gdaw’s picture

gdaw commented
Title: wxt_bootstrap wcag - unnecessary roles banner/navigation/main/article/ » wxt_bootstrap wcag - unnecessary roles banner/navigation/main/article/contentinfo
gdaw’s picture

gdaw commented
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Looks like it will help for us.
Gdaw, should I/we add this patch in our build?

gdaw’s picture

gdaw commented

Since this patch resolves only Warning messages so it is low priority and not a wcag fail. Also, since this patch updates a long list of twigs, we could reduce the chances of merge conflicts by letting all the other wcag patches go through first, and delay this particular patch to be included in a future release.

gdaw’s picture

gdaw commented
Status: Needs review » Postponed

Marking this as postponed, after the next release I can generate a fresh patch that avoids conflicts with my other patches.

sylus’s picture

sylus commented

Is this issue still needed?

If so could generate a new and updated patch?

Thanks!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@gdaw , please review and reroll this patch if still needed (which I suspect it might be).

If you need assistance with re validation I can spin up a w3c docker container for w3c validation for this which I should probably just leave running all the time anyway.

send me a Private Message for details.

gdaw’s picture

gdaw commented
Version: 8.x-3.012 » 8.x-3.x-dev
Assigned: Unassigned » gdaw
Status: Postponed » Active
gdaw’s picture

gdaw commented
Version: 8.x-3.x-dev » 4.0.x-dev
StatusFileSize
new wxt_bootstrap-w3c_warnings_unnecessary_roles-3154001-11.patch17.22 KB

This patch cleans up the remaining unnecessary roles that other patches did not cover. There should be no impact but the various validation tools will display fewer warnings and tips.

gdaw’s picture

gdaw commented
Assigned: gdaw » Unassigned
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

looks good, took this patch, lets run some w3c tests now

gdaw’s picture

gdaw commented

No issues or errors have been noticed during the past month or two, as hoped this patch has been harmless ... and the reduced noise from validation tools is very welcome.

sylus’s picture

sylus commented
Status: Needs review » Fixed

Committed and attributed ;D

Thanks so much!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.