Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
It appears that in the Workflow module the workflow name is passed through (mangled in) check_plain() and this is now mirrored in Workflow Extensions to match the name.
This works fine, but doesn't render great, e.g. a workflow name like "Rik's Workflow" renders as "Rik's Workflow", both in Workflow and in Workflow Extensions.
Hi Ted,
No it's in 7.x-1.x-dev.
We need people like you to download and test-drive that version and report back to this issue queue with your findings.
Then if enough people confirm that it's fixed in 7.x-1.x-dev, we can confidently release a "stable" 7.x-1.0-beta4 or maybe even a 7.x-1.0 !
Look forward to your report!
Rik
Thank you for your reply. With WE 7.x-1.0-beta3+2-dev, I still have a Notice : Undefined index at line 201 of workflow_extensions.module. In my tranlated words I have replaced all letters with accent. For instance, I have replaced 'Publié' with 'Publie' and I still have the same notice.
On my install I have : Drupal core 7.22, Internationalization 7.x-1.8 and Workflow 7.x-1.1
Ok, then it is most likely something to do with translations as I definitely fixed the special character thing...
Looks like translations are not being supported sufficiently in either the Workflow or Workflow Extensions 7.x-1.x-dev modules.
Just so that we can zoom in on the root cause... If you disable (but not uninstall) Internationalization, does the error/notice disappear?
Rik
When I disable Internationalization the error/notice disappear.
When Internationalization is activated, I can create content in english with no notice and the 3 form styles (Radio buttons, Single-action buttons and Dropdown selector) work like expected.
The notice appears when I try to create content in french and in this case, the selection of Single-action buttons or Dropdown selector styles work like Radio buttons style selection.
To reproduce the notice, you can install : Drupal core 7.22 (with Content translation and Locale), Variable 7.x-2.2, Internationalization 7.x-1.8, Language Switcher Dropdown 7.x-1.5, Revisioning 7.x-1.4, Workflow 7.x-1.1 and Workflow Extensions 7.x-1.0-beta3+2-dev.
Sure I only put that in days ago to match same in Workflow. I've taken it out again.
Note that if the translation does not contain special characters the absence or presence of check_plain() won't make difference.
Comments
Comment #1
nancydruMight want to look at:
Looks like WE has an issue with workflow names with quotes in them.
Comment #2
Ted51 commentedI get the same notice with WE 7.x-1.0-beta3 release after translating UI.
Comment #3
rdeboerFixed with latest check-in.
It appears that in the Workflow module the workflow name is passed through (mangled in)
check_plain()and this is now mirrored in Workflow Extensions to match the name.This works fine, but doesn't render great, e.g. a workflow name like "Rik's Workflow" renders as "Rik's Workflow", both in Workflow and in Workflow Extensions.
Rik
Comment #4
rdeboerComment #5
Ted51 commentedIs'it fixed for WE 7.x-1.0-beta3 too ?
Comment #6
rdeboerHi Ted,
No it's in 7.x-1.x-dev.
We need people like you to download and test-drive that version and report back to this issue queue with your findings.
Then if enough people confirm that it's fixed in 7.x-1.x-dev, we can confidently release a "stable" 7.x-1.0-beta4 or maybe even a 7.x-1.0 !
Look forward to your report!
Rik
Comment #7
Ted51 commentedHi RdeBoer,
Thank you for your reply. With WE 7.x-1.0-beta3+2-dev, I still have a Notice : Undefined index at line 201 of workflow_extensions.module. In my tranlated words I have replaced all letters with accent. For instance, I have replaced 'Publié' with 'Publie' and I still have the same notice.
On my install I have : Drupal core 7.22, Internationalization 7.x-1.8 and Workflow 7.x-1.1
Thank you for your help
Comment #8
rdeboerOk, then it is most likely something to do with translations as I definitely fixed the special character thing...
Looks like translations are not being supported sufficiently in either the Workflow or Workflow Extensions 7.x-1.x-dev modules.
Just so that we can zoom in on the root cause... If you disable (but not uninstall) Internationalization, does the error/notice disappear?
Rik
Comment #9
Ted51 commentedWhen I disable Internationalization the error/notice disappear.
When Internationalization is activated, I can create content in english with no notice and the 3 form styles (Radio buttons, Single-action buttons and Dropdown selector) work like expected.
The notice appears when I try to create content in french and in this case, the selection of Single-action buttons or Dropdown selector styles work like Radio buttons style selection.
Hope this can help to fix the issue.
Comment #10
nancydruI saw the error this morning, Rik. But it seems to have gone away when I fix the special character issue.
As for the special characters, that is on Workflow. #1972728: Special Characters in Workflow name
Comment #11
Ted51 commented#10 don't solve the issue for me.
Comment #12
nancydru@Ted51: Could you provide a screen shot, please?
Comment #13
Ted51 commentedHi NancyDru,
To reproduce the notice, you can install : Drupal core 7.22 (with Content translation and Locale), Variable 7.x-2.2, Internationalization 7.x-1.8, Language Switcher Dropdown 7.x-1.5, Revisioning 7.x-1.4, Workflow 7.x-1.1 and Workflow Extensions 7.x-1.0-beta3+2-dev.
Comment #14
rdeboerOk, so we've isolated the issue. Changing title.
Comment #15
nancydruPlease try going to line 200 in workflow.pages.inc and remove the check_plain(). Let's see if that helps.
Rik, we need to look at the return in workflow_extensions_extract_workflow_name(). It probably should not have the check_plain().
Comment #16
nancydruHere's a patch for WE. There needs to be a companion patch in Workflow (#1972728: Special Characters in Workflow name).
Comment #17
Ted51 commentedHi NancyDru,
I have removed patch of #10 and applied the two patchs of #16 but I still have the same notice.
Comment #18
nancydruThere will be a new -dev release of Workflow later this evening. After trying that, a new screenshot might help me.
Comment #19
rdeboer@NancyDru #15:
Sure I only put that in days ago to match same in Workflow. I've taken it out again.
Note that if the translation does not contain special characters the absence or presence of check_plain() won't make difference.
Rik
Comment #20
nancydruYes, that's correct. As it turns out, I had set up a test workflow called "Nancy's Excellent Workflow" so I had been seeing this already.
After making these changes, I also tested with a workflow named "
alert('uh oh');" to make sure we weren't introducing security issues. That is properly escaped now and quotes look like quotes.
Comment #21
rdeboerSo at the end of all that what does this mean for Ted51's issue with translations? Has that come out of the wash clean?
Comment #22
nancydruIIRC, you will still need the patch I submitted, then everything should be okay. Looks like you've already done that, so let's close this.
Comment #23
rdeboerThe patch just changes Workflow Extensions back to what it was.
So, ok, closing.