Patch for the comment [#1264046]

Comment	File	Size	Author
#2	comment_styling-1264046-3.patch	1.99 KB	prathK
	patch_comment_layout.zip	1.71 KB	prathK

Comment #1

Matt V. CreditAttribution: Matt V. commented 8 September 2011 at 04:51

Status:

Patch (to be ported)

» Needs work

prathK,

Thanks for the patch!

My hope with the theme was to try to stay as true as possible to the original design of the Whiteboard Framework. With that in mind, I'd like to keep the CSS changes to a minimum, if possible. I'd prefer to modify the tpl.php and the template.php files instead. Up to now, I've been able to keep the style.css file unchanged from the original WordPress file. The few CSS changes I did have to make were done to the theme.css file, mostly to change class names that differ between WordPress and Drupal.

Also, I had some trouble apply the patch files. Can you try using the steps on the Version control tab to generate a new patch? Thanks again!

Log in or register to post comments

Comment #2

prathK CreditAttribution: prathK commented 9 September 2011 at 19:14

File	Size
comment_styling-1264046-3.patch	1.99 KB

Hi Matt,

I have created the patch using the procedure given.
Actually earlier I created the patch using win-merge.
The one I have created now is using git instructions given from your link.
Also I have moved the changes from the style.css to theme.css as it will contain all the custom changes
for the current theme. and I agree with you that we should avoid major changes in style.css.
Good luck !!!!
I hope this patch will work successfully. :)
Let me know..

Regards,
prathK

Log in or register to post comments

Comment #3

prathK CreditAttribution: prathK commented 19 October 2011 at 04:17

Status:

Needs work

» Closed (fixed)

Log in or register to post comments

Comment #4

Matt V. CreditAttribution: Matt V. commented 16 December 2011 at 06:53

@prathK I've applied your patch. Thanks a lot!

I also created a 6.x-1.0 release. I noticed after creating the release that there have been updates to the original WordPress theme. At some point, it would be nice to get the improvements rolled into the Drupal version too, where appropriate.

Assuming you're still interested in helping maintain the theme, I went ahead and added you as a maintainer. Let me know if you have any questions.