Closed (fixed)
Project:
Welcome mail
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Dec 2017 at 09:39 UTC
Updated:
26 Jan 2018 at 14:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
davi.uezono commentedassigning it to me, wip
Comment #3
davi.uezono commentedSample api.php file created.
Comment #4
davi.uezono commentedComment #5
davi.uezono commentedComment #6
eiriksmThanks for the patch!
Could you change the following:
+ * @param string $message
+ * The message itself.
+ */
This param is an array. The description is also misleading. You can change it to say it is a $message array, as used in drupal_mail.
Also, please change
function hook_welcome_mail_mail_alter($message) {
to
function hook_welcome_mail_mail_alter(&$message) {
...since you are required to use it like that in a custom module.
Comment #7
davi.uezono commentedok, fixing it right now.
my apologies if some contrib workflow is wrong, still trying to learn here. thanks for your patience.
Comment #8
davi.uezono commentedComment #10
eiriksmYour contrib workflow is very good!
Thanks alot for your patch. Commited now!