Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.| Comment | File | Size | Author |
|---|---|---|---|
| #5 | webpush-remove-composer-manager-dependency-3103017-5.patch | 1.94 KB | jieyyal |
| #3 | webpush-remove-composer-manager-dependency-3103017-3.patch | 1.81 KB | jieyyal |
Comments
Comment #2
jieyyal commentedRemove Composer Manager and use library to load the web-push-libs/web-push-php library..
Comment #3
jieyyal commentedHere comes the patch:
Comment #4
jieyyal commentedComment #5
jieyyal commentedUpdate the patch
Comment #6
esolitosI think we should support both composer_manager and libraries, it's not hard to do and allows to use both approaches.
Comment #7
jieyyal commentedHi @esolitos,
The patch only removed composer_manager from module dependencies.
I think composer_manager still works if we don't have library exists.
Comment #8
tmin commentedThe patch seems to be working without issues for me (haven't done extensive testing yet).
The only (potential) problem that I would like to mention is that, depending on how the user installed the library, there may not be an autoload file in the root of the directory. For example if you download the library and run composer install the autoload file is located in vendor/ directory.
Either we would have to add some documentation on the .install file's error on how exactly to add the library if not using the composer_manager module or at least mention that the library should have an autoload.php file (or softlink to the file) in the root of the library directory.
Other than that, thanks a lot for this since the composer_manager module has been acting completely strange for me and I was trying to avoid installing it at all costs.