line 230 db_query("UPDATE {webform_report}u

should be db_query("UPDATE {webform_report}

error generated:

user warning: Table 'Leadtrackeradmin.webform_reportu' doesn't exist query: UPDATE webform_reportu SET wnid = 16, kcid = 8, sort = 4, components = 'a:1:{i:-1;s:2:\\\"-1\\\";}', filter_type = 0, filter_value = '', results_per_page = 20 WHERE nid = '19' in .../sites/all/modules/webform_report/webform_report.module on line 233.

CommentFileSizeAuthor
#12 webform-results.jpg44.46 KBdecibel.places
#8 webform_report.module.patch1.4 KBdeavidsedice
#1 remove_u.patch1.09 KBpebosi

Comments

pebosi’s picture

pebosi commented
Status: Active » Needs review
StatusFileSize
new remove_u.patch1.09 KB

Created a patch.

regards

add1sun’s picture

add1sun commented
Status: Needs review » Reviewed & tested by the community

Same problem here. Please commit this patch and roll a new release. :-)

bensnyder’s picture

bensnyder commented

Same here. Pa-pa-pa-paleeeease roll a new release. There are many patches that have been sitting stale for months now :))

Magnity’s picture

Magnity commented
Priority: Normal » Critical

I also found this error.

Marking as critical as the bug renders the module unusable - i.e. cannot create a webform report.

decibel.places’s picture

decibel.places commented

@#4 Magnity

please see patch in #1

@klance the patch has been tested and reviewed, please commit

-Cursed-’s picture

-Cursed- commented

The extra "u" is still there. Not a big deal really to remove it, but it would be nice to not have there so that others don't have to change the module code.

interfaced’s picture

interfaced commented

Same thing happened to me! Easy change, but should be fixed so others don't have this prob

deavidsedice’s picture

deavidsedice commented
StatusFileSize
new webform_report.module.patch1.4 KB

I corrected this issue too.

But I found another error:

#default_value for title and description in "add new form_report" form, has "t()" function translating dynamic values.
This is causing errors in non-english installation of drupal

I've done a patch for these two errors, so I'm not creating a new issue for this.

I tested this patch and it's working in my production site.

mradamjohn’s picture

mradamjohn commented

At least a month later and it seems the problem(s) still exist.

Furthermore, my experience has been that even after applying #5 http://drupal.org/node/397300#comment-1629714 the criteria are still not saved.

Anyone else out there looking into this?

@klance
...is the module maintainer available for insight?

Thanks to all for the feedback so far..

decibel.places’s picture

decibel.places commented

@ #9 LiveLoveWorkPlay

I am using webform report with the "u" removed on a couple of sites and it works...

I have not had to apply http://drupal.org/node/397300#comment-1629714 or any other changes apart from removing the "u"

I did not use the patch, but it looks fine to me.

mradamjohn’s picture

mradamjohn commented

I think the issue is in
webform_report_criteria_form
within
webform_report.module
based on a cursory initial review.

so,
did a simple print test above the UPDATE in webform_report_update and then the node I was testing saved.

odd behaviour.. something is off.

I have to move on but will get back to this as some point, maybe as early as next week.

if anyone else can shed light on the matter... would appreciate it.

decibel.places’s picture

decibel.places commented
StatusFileSize
new webform-results.jpg44.46 KB

here is a screencap showing the webform results

@LiveLoveWorkPlay: could your problem be caused by an error in the webform?

rzelnik’s picture

rzelnik commented

submit

jimbullington’s picture

jimbullington commented
Status: Reviewed & tested by the community » Fixed
jimbullington’s picture

jimbullington commented
Status: Fixed » Closed (fixed)
jimbullington’s picture

jimbullington commented
Status: Closed (fixed) » Fixed

Also remove the unneeded t() in default_value as noted in #8

Will be included in next release

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.