i patched quite some code, for better code style

There was also some security problems with some sql queries

CommentFileSizeAuthor
#1 webform_report_style.patch18.06 KBdawehner
webform_report_style.patch18.06 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new webform_report_style.patch18.06 KB

damn i diffed the wrong way

klance’s picture

klance commented

Thanks, dereine. I can't really patch a nightly snapshot because it's likely changed a few times since you created your patch, but I get the idea from what you submitted. At the conclusion of the Drupal 6.x.1.0 port I referred to the Drupal Coding Standards page (http://drupal.org/node/318) and did a code sweep. I didn't see anything in there about commenting the end tag of functions, so I didn't do that (though I do see how it would help make it more readable).

klance’s picture

klance commented
Status: Active » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.