Fresh install with webform version 7.x-3.20 you get an undefined function for webform_replace_tokens when using the term reference field type.

Patch attached updating 3 references.
Looks like webform just renamed the function to _webform_filter_values.

** updated file with correct path.

CommentFileSizeAuthor
#3 webform_references-update_function_webform_replace_tokens.patch2.44 KBrosemaryreilman
webform_references-update_function_webform_replace_tokens.patch3.24 KBrosemaryreilman

Comments

mrsdohpaz created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, webform_references-update_function_webform_replace_tokens.patch, failed testing.

rosemaryreilman’s picture

rosemaryreilman
she/her
commented
Issue summary: View changes
StatusFileSize
new webform_references-update_function_webform_replace_tokens.patch2.44 KB
sumitmadan’s picture

sumitmadan commented

Hi mrsdohpaz,

Would you please let me know which version of webform have you installed?

m_z’s picture

m_z commented

I also use webform 7.x-3.20 and have problems after updating webform_references to its latest version.

As you can see in https://www.drupal.org/node/2179867 there were some API changes in webform 7.x-4.x that lead to the error, but the module owner of the Webform Phone Number module fixed the problem (see commit http://cgit.drupalcode.org/webform_phone/commit/?id=06eb070ddb88ad994419...). And his solution looks very similar to the provided patch.

So it would be nice if a fixed version of this module could be released that runs on webform 7.x-3.x AND 7.x-4.x. Many thanks in advance.

m_z’s picture

m_z commented

I updated my webform version to 7.x-3.24 and tested the patch that solved the problem - so the error messages are gone.

RTBC for webform 7.x-3.x

Somebody should test the patched version with webform 7.x-4.x - but chances of success are high, that it should work there.

navneet0693’s picture

navneet0693 commented

I downloaded the latest module versions of both webform and webform_reference but didn't faced any such issue, also i used webform_reference with webform 7.x-3.x but didn't encountered any such errors.

rosemaryreilman’s picture

rosemaryreilman
she/her
commented

Sumitmadan,
webform version 7.x-3.20 and webform_references 7.x-1.8+9-dev