Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Attached patch adds support for entity_cache used in combination with entity_translation.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | webform_localization-add_support_for_entity_cache-2425161-11.patch | 988 bytes | joseph.olstad |
Comments
Comment #1
attiks commentedComment #3
joseph.olstadComment #4
joseph.olstadThanks @attiks , just had to refactor the patch, lets put it through some review and testing.
Comment #5
joseph.olstadhi attiks, so by using entity_cache we should get improved performance? or is there other reasons to use it?
Comment #6
attiks commented#5 Depending on the backend you use for the cache you get a huge speed improvement in loading entities.
Comment #7
joseph.olstadHi @attiks, thanks for the patch, looks like great work.
There were some recent changes to the module so maybe we might want to re-run the new simpletests on it.
Comment #10
joseph.olstadTODO: Patch needs a reroll due to other more recent changes.
I'll try to get this rerolled soon.
Attiks, thanks again for your work on this, greatly appreciated, I should be able to take it from here.
Comment #11
joseph.olstadOk, I refactored this patch, lets put it through testing.
Comment #12
joseph.olstadAssigning to joel_osc for review. simpletest tests are all passing but maybe we should confirm whether or not simpletest is able to test entity_cache or not?
Attiks has a very good reputation, this is not because I doubt his code, it is just to have another review before we commit this performance patch.
Comment #14
joseph.olstad