Closed (fixed)
Project:
Webform2Sugar
Version:
6.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Feb 2012 at 17:30 UTC
Updated:
19 Feb 2013 at 07:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
jeffamHere's the patch.
I've also made a sandbox fork of this module, and these changes are maintained in the 6.x-4.x_custom_fields_ui branch. One could add that sandbox repo as a remote and pull the changes in that way, too.
Comment #2
rurri commentedThanks for the patch.
This feature is already available in the latest version of webform2sugar (7.5.x), but this is great way to add to older version (6.4.x).
The only note is that while correct to remove the long list of custom field options from the webform2sugar_fields.inc file, I don't think this is a good idea since it would break backwards compatibility without an update script to find any webforms using any of those fields and creating custom fields for them.
So I would say those either need to be left in the .inc file, or there needs to be an _update() function created to convert the data.
Comment #3
jeffamGood point. Here's the patch without the default custom fields removed.
Comment #4
rurri commentedLooks good to me. Will add to my list of things to test.
Comment #5
rurri commentedCommitted to dev