hi all

we want to ask you, if you plan to develop this module further and if any release for drupal 9 is planed?

CommentFileSizeAuthor
#2 3169247-2.patch3.82 KBsahana _n

Comments

cola created an issue. See original summary.

sahana _n’s picture

Status: Active » Needs review
StatusFileSize
new3.82 KB

Please review the patch, replaced deprecated methods.

cola’s picture

Thank you for the patch, can you tel me which version of the module you test it? we cannot apply the patch

cola’s picture

The patch is not working, bellow the errors

Executing command (CWD): git -C 'modules/contrib/wallee' apply --check -v '-p1' '/tmp//5f61dbda63d3d.patch'
Checking patch src/Controller/InvoiceController.php...

error: while searching for:
      ->loadRevision($invoice_revision);
    return $this->t('Revision of %title from %date', [
      '%title' => $invoice->label(),
      '%date' => format_date($invoice->getRevisionCreationTime()),
    ]);
  }


error: patch failed: src/Controller/InvoiceController.php:47
error: src/Controller/InvoiceController.php: patch does not apply
Checking patch src/Form/InvoiceForm.php...

Hunk #1 succeeded at 55 (offset -2 lines).
Checking patch src/Form/InvoiceRevisionRevertForm.php...

error: while searching for:
        '%title' => $this->revision->label(),
        '%revision' => $this->revision->getRevisionId(),
      ]);
    drupal_set_message(t('Invoice %title has been reverted to the revision from %revision-date.', [
      '%title' => $this->revision->label(),
      '%revision-date' => $this->dateFormatter->format($original_revision_timestamp),
    ]));

error: patch failed: src/Form/InvoiceRevisionRevertForm.php:124
error: src/Form/InvoiceRevisionRevertForm.php: patch does not apply
Checking patch src/WalleeService.php...

error: while searching for:
use Drupal\commerce_order\Entity\OrderInterface;
use Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException;
use Drupal\Component\Plugin\Exception\PluginNotFoundException;
use Drupal\file\Entity\File;
use Wallee\Sdk\Model\TransactionCreate;
use Wallee\Sdk\Model\LineItemCreate;

error: patch failed: src/WalleeService.php:6
error: src/WalleeService.php: patch does not apply

Testing ability to patch with git apply. This command may produce errors that can be safely ignored.
git -C 'modules/contrib/wallee' apply --check -v '-p0' '/tmp//5f61dbda63d3d.patch'
Executing command (CWD): git -C 'modules/contrib/wallee' apply --check -v '-p0' '/tmp//5f61dbda63d3d.patch'
Checking patch a/src/Controller/InvoiceController.php => b/src/Controller/InvoiceController.php...

error: a/src/Controller/InvoiceController.php: No such file or directory

Checking patch a/src/Form/InvoiceForm.php => b/src/Form/InvoiceForm.php...
error: a/src/Form/InvoiceForm.php: No such file or directory
Checking patch a/src/Form/InvoiceRevisionRevertForm.php => b/src/Form/InvoiceRevisionRevertForm.php...
error: a/src/Form/InvoiceRevisionRevertForm.php: No such file or directory
Checking patch a/src/WalleeService.php => b/src/WalleeService.php...
error: a/src/WalleeService.php: No such file or directory

Testing ability to patch with git apply. This command may produce errors that can be safely ignored.
git -C 'modules/contrib/wallee' apply --check -v '-p2' '/tmp//5f61dbda63d3d.patch'
Executing command (CWD): git -C 'modules/contrib/wallee' apply --check -v '-p2' '/tmp//5f61dbda63d3d.patch'
Checking patch Controller/InvoiceController.php...

error: Controller/InvoiceController.php: No such file or directory
Checking patch Form/InvoiceForm.php...
error: Form/InvoiceForm.php: No such file or directory
Checking patch Form/InvoiceRevisionRevertForm.php...
error: Form/InvoiceRevisionRevertForm.php: No such file or directory
Checking patch WalleeService.php...

error: WalleeService.php: No such file or directory

Testing ability to patch with git apply. This command may produce errors that can be safely ignored.
git -C 'modules/contrib/wallee' apply --check -v '-p4' '/tmp//5f61dbda63d3d.patch'
Executing command (CWD): git -C 'modules/contrib/wallee' apply --check -v '-p4' '/tmp//5f61dbda63d3d.patch'
error: git diff header lacks filename information when removing 4 leading pathname components (line 5)