Votingapi just stores data based on single languages, what of we want to store data based on different languages, so that we have different rating for different languages.

CommentFileSizeAuthor
#4 translatable-votingapi-8.x-3.0-beta2-3153473-2.patch17.3 KBmanojbisht_drupal
#2 translatable-votingapi-3153473-1.patch21.79 KBmanojbisht_drupal

Comments

manojbisht_drupal created an issue. See original summary.

manojbisht_drupal’s picture

manojbisht_drupal commented
Status: Active » Needs review
StatusFileSize
new translatable-votingapi-3153473-1.patch21.79 KB

Belo Patch fixes this issue, it makes votingapi translatable, also, an install hook is written for making it translatable, in case module is already written.

Status: Needs review » Needs work

The last submitted patch, 2: translatable-votingapi-3153473-1.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

manojbisht_drupal’s picture

manojbisht_drupal commented
StatusFileSize
new translatable-votingapi-8.x-3.0-beta2-3153473-2.patch17.3 KB

Below patch is for 8.x-3.0-beta2

manojbisht_drupal’s picture

manojbisht_drupal commented
Status: Needs work » Needs review
tr’s picture

tr commented
Status: Needs review » Needs work

Patch in #4 doesn't apply, patch in #2 fails tests and introduces 35 new coding standards violations. You didn't provide an interdiff so I don't know the difference between the two.

Patches need to be made against 8.x-3.x - the beta2 version cannot be changed.

You also changed a lot of things that seem to be unrelated to language - those should be separate issues, please don't include anything in the patch unless it is directly connected to "Making Votingapi Translatable".

Since language is a property inherited from the ContentEntityBase, a lot of this patch isn't needed, but this will have to wait until the refactoring of the Vote entity is complete. And that refactoring is currently on hold until some of the existing issues get committed (I'll open a new issue with my work in progress so you can see what I'm talking about) - dealing with interlocking issues will just make it harder to get things done here, so it would help a lot of you could review the existing issues..

tr’s picture

tr commented

See #3153550: Vote entity unnecessarily re-implements features provided by base class for a patch that will make the language base field available without having to explicitly define it in the Vote entity. Your hook_update_N() functions could be useful in that issue.

tr’s picture

tr commented
Priority: Normal » Major
tr’s picture

tr commented
Version: 8.x-3.x-dev » 4.0.x-dev